Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label for indicators #868

Closed
1 of 2 tasks
KKaselkar opened this issue Aug 24, 2018 · 5 comments
Closed
1 of 2 tasks

Label for indicators #868

KKaselkar opened this issue Aug 24, 2018 · 5 comments
Assignees

Comments

@KKaselkar
Copy link

KKaselkar commented Aug 24, 2018

PD number: IRQ/PCA2018245/PD2018441
dev.prp environment
Iraq workspace
demo pmp environment

Label for indicators doesn't display the actual value in all the places where a label value should appear.
Also label should not appear for quantity type indicator.

technical note

  • Make sure we're syncing the label values
  • In ip reporting only (no change to cluster) show labels only for percent/ration, not for quantity indicators.
@KKaselkar
Copy link
Author

KKaselkar commented Aug 24, 2018

image

PMP:
image

@momimomo
Copy link
Contributor

momimomo commented Aug 30, 2018

I'm getting null label value (label.label) in all responses for indicator reports from backend. (https://dev.partnerreportingportal.org/) - front end seems to be OK.

screen shot 2018-08-30 at 23 22 34

as for #2 - visibility limited as requested. Issuing PR.

@KKaselkar
Copy link
Author

@sethgold8 this still doesnt work for quantity type of indicators
Quantity indicators for ip PRP do not have labels so "Data Key []" must not be displayed for quantity type of indicator both in PRP and PMP

@sethgold8
Copy link
Contributor

sethgold8 commented Oct 8, 2018

@KKaselkar

Want to keep this board focused on PRP items. The only PMP items should, be around PRP integrations. My explanation is below. Let me know if I am misunderstanding something.

The ticket #868 you created above regarding IP says: show labels only for percent/ration

Below is an example of a Quantity indicator in IP. There is no label, hence why it was moved to UNICEF QA

Screen Shot 2018-10-08 at 9.31.06 AM.png

You can see how there are labels on this, which is a percentage indicator in IP

Screen Shot 2018-10-08 at 9.33.21 AM.png

If PMP label is the issue, please add it to the clubhouse scrum board.

@KKaselkar
Copy link
Author

checked in PRP dev its resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants