Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annex C form must be generated when the partner submits a QPR #964

Closed
1 task
KKaselkar opened this issue Oct 9, 2018 · 10 comments
Closed
1 task

Annex C form must be generated when the partner submits a QPR #964

KKaselkar opened this issue Oct 9, 2018 · 10 comments
Assignees

Comments

@KKaselkar
Copy link

KKaselkar commented Oct 9, 2018

Currently annex C form is generated in PRP when a QPR is accepted in PMP.

  • Annex C form must be generated when the report is submitted in PRP , this used to work before but has changed now
@KKaselkar
Copy link
Author

image

@sethgold8
Copy link
Contributor

the 'download Annex C' button does not work? @KKaselkar

@KKaselkar
Copy link
Author

Annex C link is not displayed in PRP until and unless report is accepted in PMP, earlier it used to generate and display the Annex C link as soon as partner used to submit the report.

@sethgold8 sethgold8 added the Ready label Oct 9, 2018
@sethgold8 sethgold8 assigned n1207n and unassigned sethgold8 Oct 9, 2018
@sethgold8
Copy link
Contributor

This may be a permission issue

@sethgold8 sethgold8 assigned groinder and unassigned n1207n Oct 10, 2018
groinder added a commit that referenced this issue Oct 11, 2018
@groinder
Copy link
Contributor

The issue was related to ID management permissions changes, I simplified some of the permissions checks although I misinterpreted this one. It's fixed now.

@sethgold8 sethgold8 added rejected and removed Ready labels Oct 11, 2018
@sethgold8
Copy link
Contributor

@groinder is there a specific PR for this? Still seeing without Download Annex C
Screen Shot 2018-10-11 at 2.38.53 PM.png

@sethgold8
Copy link
Contributor

@groinder we believe it only looks for 'accepted' status. It should also look for 'Submitted'

@groinder
Copy link
Contributor

@sethgold8 It is fixed with 0aa4544 @n1207n I've look into the sources on https://dev.partnerreportingportal.org for some reason it doesn't have this change there.

@sethgold8
Copy link
Contributor

Fixed :)

Screen Shot 2018-10-15 at 1.04.00 PM.png

@sethgold8 sethgold8 added QA and removed rejected labels Oct 15, 2018
@KKaselkar
Copy link
Author

Annex C form is generated when the report is submitted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants