fix: deactivate monthly notifications about retired review system

django/project/tasks.py

@@ -66,51 +66,6 @@ def project_review_requested_on_create_notification(review_id, custom_msg=None):
         )
 
 
-@app.task(name="project_review_requested_monthly_notification")
-def project_review_requested_monthly_notification():
-    """
-    Sends notification if a project needs review by an user - monthly celery task
-    """
-
-    incomplete_reviews = ReviewScore.objects.exclude(
-        status=ReviewScore.STATUS_COMPLETE
-    ).filter(
-        modified__lt=timezone.now()
-        - timezone.timedelta(days=settings.NOTIFICATION_PROJECT_REVIEW_DAYS)
-    )
-
-    if not incomplete_reviews:  # pragma: no cover
-        return
-
-    # limit number of mails sent
-    if not settings.EMAIL_SENDING_PRODUCTION:
-        incomplete_reviews = ReviewScore.objects.filter(
-            id=incomplete_reviews.first().id
-        )
-
-    # grab the list of users
-    addressees = UserProfile.objects.filter(
-        id__in=incomplete_reviews.values_list("reviewer", flat=True).distinct()
-    )
-
-    for addressee in addressees:
-        send_mail_wrapper(
-            subject=_("You have a new project review request"),
-            email_type="reminder_project_review_template",
-            to=addressee.user.email,
-            language=addressee.language or settings.LANGUAGE_CODE,
-            context={
-                "reviewscores": list(
-                    addressee.review_scores.filter(id__in=incomplete_reviews).order_by(
-                        "modified"
-                    )
-                ),
-                "name": addressee.name,
-                "details": _("Please review the following project(s): "),
-            },
-        )
-
-
 @app.task(name="project_still_in_draft_notification")
 def project_still_in_draft_notification():
     """

django/project/tests/notification_tests.py

@@ -9,8 +9,7 @@
 
 from country.models import Donor, DonorCustomQuestion
 from project.models import Project, Portfolio, ProjectPortfolioState
-from project.tasks import project_still_in_draft_notification, published_projects_updated_long_ago, \
-    project_review_requested_monthly_notification, project_review_requested_on_create_notification
+from project.tasks import project_still_in_draft_notification, published_projects_updated_long_ago, project_review_requested_on_create_notification
 from project.tests.setup import SetupTests
 from user.models import UserProfile
 
@@ -211,66 +210,6 @@ def test_published_projects_updated_long_ago(self, send_mail_wrapper):
             self.assertEqual(call_args_list['to'], self.user_1.email)
             self.assertIn(published_project_1, call_args_list['context']['projects'])
 
-    @mock.patch('project.tasks.send_mail_wrapper', return_value=None)
-    def test_project_review_monthly_reminder(self, send_mail_wrapper):
-        now = timezone.now()
-
-        with freeze_time(now - timezone.timedelta(days=45)):
-            # create project
-            published_project_1 = Project.objects.create(
-                name='Published project 1', data=self.published_project_data, public_id='1111')
-            published_project_1.team.add(self.profile_1)
-            published_project_2 = Project.objects.create(
-                name='Published project 2', data=self.published_project_data, public_id='1112')
-            published_project_2.team.add(self.profile_1)
-            published_project_3 = Project.objects.create(
-                name='Published project 3', data=self.published_project_data, public_id='1113')
-            published_project_3.team.add(self.profile_1)
-            # create portfolio
-            portfolio_1 = Portfolio.objects.create(name="Notification test portfolio")
-            # create reviews
-            pps_1 = ProjectPortfolioState.objects.create(project=published_project_1, portfolio=portfolio_1)
-            pps_2 = ProjectPortfolioState.objects.create(project=published_project_2, portfolio=portfolio_1)
-            pps_3 = ProjectPortfolioState.objects.create(project=published_project_3, portfolio=portfolio_1)
-            reviewscore_1, _ = pps_1.assign_questionnaire(self.profile_1)
-            reviewscore_2, _ = pps_2.assign_questionnaire(self.profile_2)
-            reviewscore_3, _ = pps_3.assign_questionnaire(self.profile_2)
-        with freeze_time(now - timezone.timedelta(days=10)):
-            # task shouldn't pick this up
-            reviewscore_4, _ = pps_2.assign_questionnaire(self.profile_1)
-
-        with override_settings(EMAIL_SENDING_PRODUCTION=True):
-            project_review_requested_monthly_notification.apply()
-
-            # task should send emails about Published project 1 and 2-3
-            self.assertEqual(len(send_mail_wrapper.call_args_list), 2)
-
-            for call in send_mail_wrapper.call_args_list:
-                call_args = call[1]
-                self.assertEqual(call_args['email_type'], 'reminder_project_review_template')
-                self.assertEqual(call_args['language'], 'en')
-
-                if call_args['to'] == self.user_1.email:
-                    # user_1 should receive notifications about published project 1
-                    self.assertEqual(call_args['context']['name'], self.profile_1.name)
-                    self.assertEqual([reviewscore_1], call_args['context']['reviewscores'])
-                else:
-                    # user_2 should receive notifications about published project 2
-                    self.assertEqual(call_args['context']['name'], self.profile_2.name)
-                    self.assertEqual({reviewscore_2, reviewscore_3}, set(call_args['context']['reviewscores']))
-        # init
-        send_mail_wrapper.call_args_list = _CallList()
-
-        with override_settings(EMAIL_SENDING_PRODUCTION=False):
-            project_review_requested_monthly_notification.apply()
-
-            # task should send email about Published project 1
-            self.assertEqual(len(send_mail_wrapper.call_args_list), 1)
-            call_args_list = send_mail_wrapper.call_args_list[0][1]
-            self.assertEqual(call_args_list['email_type'], 'reminder_project_review_template')
-            self.assertEqual(call_args_list['to'], self.user_1.email)
-            self.assertEqual([reviewscore_1], call_args_list['context']['reviewscores'])
-
     @mock.patch('project.tasks.send_mail_wrapper', return_value=None)
     def test_project_review_on_create_reminder(self, send_mail_wrapper):
         # create project

django/tiip/settings_deployed.py

@@ -43,10 +43,6 @@
         "task": 'published_projects_updated_long_ago',
         "schedule": datetime.timedelta(days=31),
     },
-    "project_review_requested_monthly_notification": {
-        "task": 'project_review_requested_monthly_notification',
-        "schedule": datetime.timedelta(days=30),
-    },
     "solution_log_task": {
         "task": "solution_log_task",
         "schedule": crontab(hour=1, minute=0),