Show icon next to sub-headings. #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ida Delphine <mida@unicef.org>
Signed-off-by: Ida Delphine <mida@unicef.org>
jwflory
approved these changes
Aug 11, 2021
There was a problem hiding this comment.
Awesome! This looks great @Idadelveloper 🥳 Approved!
There is a bug I noticed where when you click one of the header links, the heading is hidden underneath the menu bar at the top. But this bug was not introduced by this change, it is an issue somewhere else in the theme. This is a nice-to-have improvement if we get a chance to revisit later.
Closes unicef/inventory#31. Merging! 🎬
jwflory
added a commit
to unicef/inventory
that referenced
this pull request
Aug 11, 2021
This commit updates the theme submodule to include icons to copy the location of a specific sub-heading on a page. This was added by @Idadelveloper in unicef/inventory-hugo-theme#7. Closes #31. Signed-off-by: Justin W. Flory (he/him) [UNICEF Innovation] <jflory@unicef.org>
jwflory
pushed a commit
that referenced
this pull request
Aug 13, 2021
* layouts: Add icon to next to sub-headings Signed-off-by: Ida Delphine <mida@unicef.org> * assets: Styles for the icon next to sub-heading Signed-off-by: Ida Delphine <mida@unicef.org> Co-authored-by: Ida Delphine <mida@unicef.org>
jwflory
pushed a commit
that referenced
this pull request
Sep 10, 2021
* layouts: Add icon to next to sub-headings Signed-off-by: Ida Delphine <mida@unicef.org> * assets: Styles for the icon next to sub-heading Signed-off-by: Ida Delphine <mida@unicef.org> Co-authored-by: Ida Delphine <mida@unicef.org>
jwflory
pushed a commit
that referenced
this pull request
Sep 15, 2021
* layouts: Add icon to next to sub-headings Signed-off-by: Ida Delphine <mida@unicef.org> * assets: Styles for the icon next to sub-heading Signed-off-by: Ida Delphine <mida@unicef.org> Co-authored-by: Ida Delphine <mida@unicef.org>
jwflory
pushed a commit
that referenced
this pull request
Oct 10, 2021
* layouts: Add icon to next to sub-headings Signed-off-by: Ida Delphine <mida@unicef.org> * assets: Styles for the icon next to sub-heading Signed-off-by: Ida Delphine <mida@unicef.org> Co-authored-by: Ida Delphine <mida@unicef.org>
jwflory
pushed a commit
that referenced
this pull request
Oct 13, 2021
* layouts: Add icon to next to sub-headings Signed-off-by: Ida Delphine <mida@unicef.org> * assets: Styles for the icon next to sub-heading Signed-off-by: Ida Delphine <mida@unicef.org> Co-authored-by: Ida Delphine <mida@unicef.org>
jwflory
pushed a commit
that referenced
this pull request
Oct 14, 2021
* layouts: Add icon to next to sub-headings Signed-off-by: Ida Delphine <mida@unicef.org> * assets: Styles for the icon next to sub-heading Signed-off-by: Ida Delphine <mida@unicef.org> Co-authored-by: Ida Delphine <mida@unicef.org>
jwflory
pushed a commit
that referenced
this pull request
Nov 19, 2021
* layouts: Add icon to next to sub-headings Signed-off-by: Ida Delphine <mida@unicef.org> * assets: Styles for the icon next to sub-heading Signed-off-by: Ida Delphine <mida@unicef.org> Co-authored-by: Ida Delphine <mida@unicef.org>
jwflory
pushed a commit
that referenced
this pull request
Nov 23, 2021
* layouts: Add icon to next to sub-headings Signed-off-by: Ida Delphine <mida@unicef.org> * assets: Styles for the icon next to sub-heading Signed-off-by: Ida Delphine <mida@unicef.org> Co-authored-by: Ida Delphine <mida@unicef.org>
jwflory
pushed a commit
that referenced
this pull request
Dec 22, 2021
* layouts: Add icon to next to sub-headings Signed-off-by: Ida Delphine <mida@unicef.org> * assets: Styles for the icon next to sub-heading Signed-off-by: Ida Delphine <mida@unicef.org> Co-authored-by: Ida Delphine <mida@unicef.org>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to help enable easy link sharing to specific sections of the content. It addresses this issue