Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backlog of Outstanding DPG Full Submissions: #555

Closed
14 of 30 tasks
nathanbaleeta opened this issue Jun 2, 2021 · 17 comments
Closed
14 of 30 tasks

Backlog of Outstanding DPG Full Submissions: #555

nathanbaleeta opened this issue Jun 2, 2021 · 17 comments
Assignees

Comments

@nathanbaleeta
Copy link
Contributor

nathanbaleeta commented Jun 2, 2021

The following nominated projects made full submissions but have not yet been reviewed:

@nathanbaleeta nathanbaleeta self-assigned this Jun 2, 2021
@nathanbaleeta nathanbaleeta changed the title Backlog Of Outstanding DPG Full Submissions: Backlog of Outstanding DPG Full Submissions: Jun 2, 2021
@Ainali
Copy link
Contributor

Ainali commented Jun 15, 2021

As far as I can see, none of the projects above are available to review yet. Is there any way one can help on this?

@lacabra
Copy link
Contributor

lacabra commented Jun 15, 2021

Hi @Ainali, thanks for your offer to help; very much appreciated: The short answer to your question is Yes 🙂

Here's some background: We started accepting submissions with an inadequate Google Form that did not integrate nicely with this repo, and we would store their answers on a spreadsheet, which would then need to be manually encoded into json files and added to this repo.

We recently (April 2021) upgraded our submission form (repo, live form), and that integration now happens automatically, so we can keep up with any submissions we receive through the new form, but we are behind encoding and reviewing the ones that we received with the old Google Form. Thus, the first step would be to encode those entries into JSON, and @nathanbaleeta will do the first pass at reviewing them, and reaching out to the project contact if additional information is required from them.

Because that spreadsheet contains some personal information, I don't feel comfortable giving anyone else access directly, but (option A) I can copy/paste the info that we received from any of the above projects into plain text, and you can encode it into JSON We could also look into scripting it (option B), and converting from CSV into JSON, but it will require some additional work, it may or may not be worth it. I can provide a "cleaned up" version of that spreadsheet that contains all of the projects above, with the personal information removed. The script would look like a more complex version of this related one.

Let me know if you are interested in helping out with Option A or Option B. Also, @nathanfletcher may be able to help.

@Ainali
Copy link
Contributor

Ainali commented Jun 17, 2021

Thanks @lacabra! Me and my colleague @ericherman could have a go at option B.

@lacabra
Copy link
Contributor

lacabra commented Jun 17, 2021

@Ainali & @ericherman: Amazing! 🙌

Here is a copy of the spreadsheet that contains the submissions from the projects listed above not yet encoded into JSON (and linked to their respective PR). I count 19 of them. My recommendation is to export it as CSV.

Take a look and let us know what you think. 3 observations:

  • Assume that all these projects are already nominated, what is missing is the full submission matching the data in this schema, and placing the corresponding JSON file in this folder
  • Once you have your first encoded JSON file, please run all the checks described here, to make sure the file is compliant, and the CI will pass.
  • When the encoded JSON files are ready, they should be added one per PR to align with our current workflow.

Happy to answer any questions. If you need a real time chat, we can chat here.
FYI, @nathanbaleeta is based in GMT+3, and I'm based GMT-7

@Ainali
Copy link
Contributor

Ainali commented Jun 30, 2021

Just commenting to let you know that we are about halfway through scripting the conversion.

@lacabra
Copy link
Contributor

lacabra commented Jun 30, 2021

Thanks for the update @Ainali, and thanks for your efforts on this front 🙏

@ericherman
Copy link
Contributor

@lacabra we have a rough draft now ( https://github.com/ericherman/dpg-csv-to-json ). We have not yet tried to run the checks, nor split the data into separate submission files.

@lacabra
Copy link
Contributor

lacabra commented Jul 19, 2021

@ericherman Cool, cool; let me know when you do the split and run the checks, eager to take a look then.

@ericherman
Copy link
Contributor

@lacabra seems to pass the checks now.

I believe all you need to do is:

git clone -o upstream git@github.com:ericherman/dpg-csv-to-json.git
cd dpg-csv-to-json
npm install
node ./dpgs-transform-main.js

And the result files should be in the out subdirectory.

@ericherman
Copy link
Contributor

The docs at https://github.com/unicef/publicgoods-candidates/blob/master/docs/development.md#ci---continous-integration say

./scripts/check-filenames.bash checks that all data files are named consistely, that is by using the field name in kebab-case, in which punctuation is removed and spaces are replaced by single hyphens.

but ./scripts/check-filenames.bash expects parenthesis to remain, and everything after a colon to be removed.

We aligned the file naming with the expectations of script, rather than the docs.

Ainali added a commit to Ainali/publicgoods-candidates that referenced this issue Jul 20, 2021
Ainali added a commit to Ainali/publicgoods-candidates that referenced this issue Jul 20, 2021
Works towards DPGAlliance#555

Co-authored-by: Eric Herman <eric@publiccode.net>
@Ainali
Copy link
Contributor

Ainali commented Jul 20, 2021

@lacabra I created #639, did I get it right?

@lacabra
Copy link
Contributor

lacabra commented Jul 21, 2021

@lacabra I created #639, did I get it right?

@Ainali, yes, it looks very good to me, and as you can see the CI passes, which is also a very good sign. I would like to get confirmation from @nathanbaleeta, who is the person who will review and processes PRs like that for final confirmation, and then you can submit all the rest. This is very exciting 🙌

@nathanbaleeta
Copy link
Contributor Author

nathanbaleeta commented Jul 21, 2021

@lacabra I created #639, did I get it right?

@Ainali this looks nice and clean. Great job! Please proceed with submitting the remaining submissions.

Ainali added a commit to Ainali/publicgoods-candidates that referenced this issue Jul 22, 2021
Works towards DPGAlliance#555

Co-authored-by: Eric Herman <eric@publiccode.net>
ericherman added a commit to ericherman/publicgoods-candidates that referenced this issue Jul 22, 2021
Ainali added a commit to Ainali/publicgoods-candidates that referenced this issue Jul 22, 2021
Works towards DPGAlliance#555

( created with https://github.com/ericherman/dpg-csv-to-json )

Co-authored-by: Eric Herman <eric@publiccode.net>
ericherman added a commit to ericherman/publicgoods-candidates that referenced this issue Jul 22, 2021
Ainali added a commit to Ainali/publicgoods-candidates that referenced this issue Jul 22, 2021
Works towards DPGAlliance#555

( created with https://github.com/ericherman/dpg-csv-to-json )

Co-authored-by: Eric Herman <eric@publiccode.net>
Ainali referenced this issue in Ainali/publicgoods-candidates Jul 22, 2021
Works towards unicef#555

( created with https://github.com/ericherman/dpg-csv-to-json )

Co-authored-by: Eric Herman <eric@publiccode.net>
ericherman added a commit to ericherman/publicgoods-candidates that referenced this issue Jul 22, 2021
ericherman added a commit to ericherman/publicgoods-candidates that referenced this issue Jul 22, 2021
Ainali referenced this issue in Ainali/publicgoods-candidates Jul 22, 2021
Works towards unicef#555

( created with https://github.com/ericherman/dpg-csv-to-json )

Co-authored-by: Eric Herman <eric@publiccode.net>
ericherman added a commit to ericherman/publicgoods-candidates that referenced this issue Jul 22, 2021
Ainali referenced this issue in Ainali/publicgoods-candidates Jul 22, 2021
Works towards unicef#555

( created with https://github.com/ericherman/dpg-csv-to-json )

Co-authored-by: Eric Herman <eric@publiccode.net>
@Ainali Ainali mentioned this issue Jul 22, 2021
ericherman added a commit to ericherman/publicgoods-candidates that referenced this issue Jul 22, 2021
Ainali referenced this issue in Ainali/publicgoods-candidates Jul 22, 2021
Works towards unicef#555

( created with https://github.com/ericherman/dpg-csv-to-json )

Co-authored-by: Eric Herman <eric@publiccode.net>
@Ainali Ainali mentioned this issue Jul 22, 2021
ericherman added a commit to ericherman/publicgoods-candidates that referenced this issue Jul 22, 2021
@Ainali
Copy link
Contributor

Ainali commented Jul 22, 2021

@lacabra I created #639, did I get it right?

@Ainali this looks nice and clean. Great job! Please proceed with submitting the remaining submissions.

@lacabra We believe we added all of the ones that were in the csv file. They still might need some cleanup since some of the data had freeform format.

@lacabra
Copy link
Contributor

lacabra commented Jul 22, 2021

This looks great @Ainali, thanks a lot, you and @ericherman both rock! 🙌

I have updated the description of this issue to link to all the PRs, and as you can see they are all covered, and @nathanbaleeta has already started working on the one you submitted yesterday.

Much appreciated! 🙏

@ericherman
Copy link
Contributor

Pleasure to be able to contribute. Keep up the great work! <3

nathanbaleeta added a commit that referenced this issue Aug 19, 2021
nathanbaleeta added a commit that referenced this issue Aug 19, 2021
nathanbaleeta added a commit that referenced this issue Sep 8, 2021
Add DPG: ICE (Immunization Calculation Engine, Issue #555)
nathanbaleeta added a commit that referenced this issue Sep 9, 2021
nathanbaleeta added a commit that referenced this issue Sep 13, 2021
@nathanbaleeta nathanbaleeta changed the title Backlog of Outstanding DPG Full Submissions: Backlog of Blocked DPG Submissions: Mar 4, 2022
@nathanbaleeta nathanbaleeta changed the title Backlog of Blocked DPG Submissions: Backlog of Outstanding DPG Full Submissions: Mar 4, 2022
@nathanbaleeta
Copy link
Contributor Author

nathanbaleeta commented Sep 19, 2022

Closing this issue as the new tracker board serves as the current single source of truth for all projects previously existent in the backlog list. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants