Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple peers per client and better peer disconnection handling #2

Merged
merged 20 commits into from
Apr 5, 2024
Merged

Multiple peers per client and better peer disconnection handling #2

merged 20 commits into from
Apr 5, 2024

Conversation

poshcoe
Copy link
Collaborator

@poshcoe poshcoe commented Apr 5, 2024

API changes and improvements to just-webrtc-signalling (breaking):

  • Server now uses flume and async-broadcast channels for performance and to remote the tokio dependency.
  • Client gRPC connections are now lazy initiated on both wasm and native
  • Introduced RtcSignallingClientBuilder for configuration and building clients
  • New RtcSignallingPeer enables multiple peers per client
  • RtcSignallingPeer uses revamped concurrent state machine (RtcSignallingPeer::step), improved from the old RtcSignallingClient::run.
  • Peers can now be "torn down" when finished, providing a clean peer disconnection option.
  • Dirty peer disconnections are now detected on both client and server and handled appropriately.
  • Several improvements/clean-ups on the client-side API

@poshcoe
just-webrtc-signalling: use flume and async-broadcast over `tokio…
2d6802e 
…::sync`
@poshcoe
just-webrtc-signalling/src/client.rs: lazy native client connection
ca3529b
@poshcoe
signalling-peer/src/main.rs: use new sync client creation
67c97d5
@poshcoe
just-webrtc-signalling/src/client.rs: refactor for multiple peers per…
30f8d62 
… client

* multiple peers per clients
* default callbacks, with `set_on` methods
* `step` method for running async state machine
@poshcoe
just-webrtc-signalling/src/client.rs:
2b9132c 
* remove `SignalSet` in favour of direct generic tuples.
* fix `set_on..` methods to pass callback via strict generics
@poshcoe
signalling-peer/src/main.rs: update to use client buider, signalling …
3ac5bd6 
…peer and `step` method
@poshcoe
just-webrtc-signalling/src/client.rs: revert to mutex on client inner
08d521c
@poshcoe
just-webrtc-signalling/src/server.rs: remove old log msg
d96e6aa
@poshcoe
just-webrtc-signalling/src/client.rs: peer thread safety note
110f200
@poshcoe
just-webrtc-signalling: add signalling test
8df847d
@poshcoe
signalling-peer/src/main.rs: use updated signalling peer with lifetimes
d8f3eed
@poshcoe
just-webrtc-signalling/src/client.rs: provide signalling state functi…
4fad5b7 
…on abstraction
@poshcoe
just-webrtc-signalling: fmt pass
75555f1
@poshcoe
signalling-peer/src/main.rs: fmt and clippy
10f698e
@poshcoe
just-webrtc-signalling/proto/main.proto: add peer teardown service me…
0fdd9c7 
…thod
@poshcoe
just-webrtc-signalling/src/server.rs: implement teardown method and a…
de405b4 
…dd disconnected peer detection
@poshcoe
just-webrtc-signalling/src/client.rs: handle de-synced peers list and…
afbcfdf 
… implement teardown handlers
@poshcoe
just-webrtc-signalling/tests/signalling.rs: test readability
f845f99
@poshcoe
just-webrtc-signalling/README.md: update client example
f84b3b1
@poshcoe
just-webrtc-signalling/Cargo.toml: bump minor version 0.2.0
567590a
@poshcoe poshcoe merged commit df11972 into main Apr 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@poshcoe