Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-14128 Update readme and ICU4J libs to Sep 22 (ICU tag cldr/2020-09-22) #731

Conversation

pedberg-icu
Copy link
Contributor

Checklist

Update ICU4J libs in CLDR to version in ICU at end-of-day 2020-09-22 (tagged in ICU as "cldr/2020-09-22"; ICU git hash 3d8ae5eb6...). Also update CLDR readme for beta.

Copy link
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, hopefully for one of the last few times we check in a jar!

@srl295
Copy link
Member

srl295 commented Sep 23, 2020

@pedberg-icu by the way, the maven push needs a 'release' not just a tag. I've created one at https://github.com/unicode-org/icu/releases/tag/cldr%2F2020-09-22 from the tag. (You can go in and edit a tag and turn it into a release. )

On the 'create a release' page you can specify the tag, and check a box that says 'this is not production ready' (which I have done).

edit So the tagging was great, thanks, and I added the release to create the asset. (All of the above is on the ICU repo, not this one).

@srl295 srl295 merged commit b3254d3 into unicode-org:master Sep 23, 2020
srl295 added a commit to srl295/cldr that referenced this pull request Sep 23, 2020
- switch settings from srl295 to unicode-org
- parallel to b3254d3 / unicode-org#731
- will update developer docs to explain how to configure maven
@pedberg-icu pedberg-icu deleted the CLDR-14128-update-readme-and-ICU4J-libs-to-Sep-22 branch September 23, 2020 15:08
srl295 added a commit that referenced this pull request Sep 23, 2020
- switch settings from srl295 to unicode-org
- parallel to b3254d3 / #731
- will update developer docs to explain how to configure maven
pedberg-icu added a commit that referenced this pull request Sep 24, 2020
pedberg-icu pushed a commit that referenced this pull request Sep 24, 2020
- switch settings from srl295 to unicode-org
- parallel to b3254d3 / #731
- will update developer docs to explain how to configure maven

(cherry picked from commit a3b5145)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants