Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate RuleBreakPropertyTable to CodePointTrie #1835

Closed
sffc opened this issue May 2, 2022 · 0 comments · Fixed by #1839
Closed

Migrate RuleBreakPropertyTable to CodePointTrie #1835

sffc opened this issue May 2, 2022 · 0 comments · Fixed by #1839
Assignees
@sffc
Labels
C-segmentation Component: Segmentation S-small Size: One afternoon (small bug fix or enhancement) T-core Type: Required functionality
Milestone
ICU4X 0.7 Sprint B

Comments

@sffc
Copy link
Member

sffc commented May 2, 2022

Currently RuleBreakPropertyTable has an inefficient mapping from code points to properties. We should replace this with a CodePointTrie for better data size.

icu4x/experimental/segmenter/src/provider.rs

Line 44 in 1199f96

pub struct RuleBreakPropertyTable<'data>(

Part of #1653

CC @robertbastian @eggrobin
@sffc sffc added T-core Type: Required functionality C-segmentation Component: Segmentation S-small Size: One afternoon (small bug fix or enhancement) labels May 2, 2022
@sffc sffc added this to the ICU4X 0.7 Sprint A milestone May 2, 2022
@sffc sffc self-assigned this May 2, 2022
@sffc sffc mentioned this issue May 2, 2022
Closed
This was referenced May 25, 2022
Closed
Merged
@sffc sffc closed this as completed May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sffc sffc

Labels
C-segmentation Component: Segmentation S-small Size: One afternoon (small bug fix or enhancement) T-core Type: Required functionality
Projects
None yet
Milestone
ICU4X 0.7 Sprint B
Development

Successfully merging a pull request may close this issue.

Use CodePointTrie in Segmenter sffc/omnicu
1 participant
@sffc