Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thoughts on the current data pipeline design. #26

Closed
hagbard opened this issue Apr 2, 2020 · 3 comments · Fixed by #145
Closed

Thoughts on the current data pipeline design. #26

hagbard opened this issue Apr 2, 2020 · 3 comments · Fixed by #145
Assignees
Labels
A-design Area: Architecture or design C-data-infra Component: provider, datagen, fallback, adapters R-obsolete Resolution: This issue is no longer relevant T-docs-tests Type: Code change outside core library
Milestone

Comments

@hagbard
Copy link
Contributor

hagbard commented Apr 2, 2020

Current design:
https://github.com/unicode-org/omnicu/blob/master/docs/data-pipeline.md

Brainstorming doc (please comment):
https://docs.google.com/document/d/1s_DE6zH27yGNv7rcfZEL8K3Hd0F3eIwMEUmbr7qs3lM/edit#

I think that either I am completely misunderstanding what the intended use case for the design is, or it's worth rethinking some of it. Please comment on the doc.

@sffc
Copy link
Member

sffc commented Apr 4, 2020

Thanks for this. I replied inline in the doc.

I think we're thinking the same thing, just not fully aligned on terminology. I also agree that it's probably better for data hunks to be a bit larger than the current proposal.

@sffc sffc added the T-docs-tests Type: Code change outside core library label Apr 16, 2020
@sffc
Copy link
Member

sffc commented Apr 16, 2020

David: can you respond to the responses and additional questions I left in your doc, such that we can get on the same page about the data provider? I would like to iterate on the data provider design with your feedback.

@sffc sffc added C-process Component: Team processes A-design Area: Architecture or design C-data-infra Component: provider, datagen, fallback, adapters and removed C-process Component: Team processes labels May 7, 2020
@sffc sffc added this to the 2020 Q2 milestone Jun 17, 2020
@sffc
Copy link
Member

sffc commented Jun 26, 2020

A data provider POC is now checked into the repo, and we have a greater understanding of some of the key takeaways from David's doc, including larger chunk sizes (documented in #145) and error handling (#153). We have a separate issue open to discuss how you pass the data provider to the APIs (#150). I don't know what specifically remains as actionable on this issue, so I am closing it. @hagbard, if you have further suggestions, please open follow-up tickets.

@sffc sffc closed this as completed Jun 26, 2020
@sffc sffc linked a pull request Jun 26, 2020 that will close this issue
@sffc sffc added the R-obsolete Resolution: This issue is no longer relevant label Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-design Area: Architecture or design C-data-infra Component: provider, datagen, fallback, adapters R-obsolete Resolution: This issue is no longer relevant T-docs-tests Type: Code change outside core library
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants