Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fuzz the calendars crate #2713

Closed
Manishearth opened this issue Oct 3, 2022 · 1 comment · Fixed by #4904
Closed

Fuzz the calendars crate #2713

Manishearth opened this issue Oct 3, 2022 · 1 comment · Fixed by #4904
Labels
C-calendar Component: Calendars good first issue Good for newcomers help wanted Issue needs an assignee T-enhancement Type: Nice-to-have but not required
Milestone
Backlog ⟨P4⟩

Comments

@Manishearth
Copy link
Member

Manishearth commented Oct 3, 2022 •
edited
Loading

We have a lot of bugs like #2254, #2704, #2703

We should use cargo fuzz to write fuzzers that:

  • Test that calendar conversions roundtrip
  • Test that calendar arithmetic APIs work

cargo fuzz is super easy to use and does expected type conversion for you; which ought to be highly useful for this.

For the roundtrip tests we can either write one test per calendar, or perhaps have an Arbitrary-deriving enum that selects between calendars (we could also use AnyCalendarKind for this but then it would have to impl Arbitrary behind a feature)
@Manishearth Manishearth added T-enhancement Type: Nice-to-have but not required help wanted Issue needs an assignee labels Oct 3, 2022
@sffc sffc added the good first issue Good for newcomers label Oct 3, 2022
@sffc sffc added the backlog label Oct 17, 2022
@sffc
Copy link
Member

sffc commented Oct 22, 2022

Here are some more good links on fuzzing in Rust:

https://rust-fuzz.github.io/book/

https://google.github.io/oss-fuzz/getting-started/new-project-guide/rust-lang/

@sffc sffc added this to the Backlog milestone Dec 22, 2022
@sffc sffc added C-calendar Component: Calendars and removed backlog labels Dec 22, 2022
@sffc sffc mentioned this issue May 15, 2024
Merged
@sffc sffc closed this as completed in d938156 May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-calendar Component: Calendars good first issue Good for newcomers help wanted Issue needs an assignee T-enhancement Type: Nice-to-have but not required
Projects
None yet
Milestone
Backlog ⟨P4⟩
Development

Successfully merging a pull request may close this issue.

Fix bugs in several calendars with new continuity test sffc/omnicu
2 participants
@sffc @Manishearth