Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from lazy_static to once_cell and eventually std #3777

Open
sffc opened this issue Aug 3, 2023 · 1 comment
Open

Migrate from lazy_static to once_cell and eventually std #3777

sffc opened this issue Aug 3, 2023 · 1 comment
Labels
blocked A dependency must be resolved before this is actionable C-meta Component: Relating to ICU4X as a whole
Milestone
Backlog ⟨P4⟩

Comments

@sffc
Copy link
Member

sffc commented Aug 3, 2023

Rust 1.70 includes OnceCell and OnceLock, which mirror the APIs in the once_cell crate.

We currently use the lazy_static crate. We should change to once_cell instead, and then when we have an MSRV of 1.70, we can remove that dependency and switch over to the standard library.
@sffc sffc added the C-meta Component: Relating to ICU4X as a whole label Aug 3, 2023
@sffc sffc added this to the 1.3 Blocking ⟨P1⟩ milestone Aug 3, 2023
@sffc sffc mentioned this issue Aug 3, 2023
Merged
@Manishearth Manishearth mentioned this issue Aug 3, 2023
Merged
@sffc
Copy link
Member Author

sffc commented Aug 4, 2023

The 1.3 blocking part was solved in #3781. I'll keep the issue open to track the upgrade to std.

This is blocked on MSRV 1.70. It should be also noted that the fallible constructors for OnceCell are not in 1.70 and will take some more time to stabilize.

@sffc sffc added the blocked A dependency must be resolved before this is actionable label Aug 4, 2023
@sffc sffc modified the milestones: Backlog ⟨P4⟩, ICU4X 2.0 Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked A dependency must be resolved before this is actionable C-meta Component: Relating to ICU4X as a whole
Projects
None yet
Milestone
Backlog ⟨P4⟩
Development

No branches or pull requests
1 participant
@sffc