-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update locale canonicalization to use bcp47 alias data #746
Comments
@dminor Do you consider this to be a 1.0 blocker? Is it required for spec compliance? |
Not fixing this is a bug, but it's a pretty minor bug, the handful of missing aliases are very much edge cases. I think we can comfortably fix this post 1.0. I suggest punting it. |
My understanding so far:
|
I've obtained the Next steps:
@sffc do you see anything that I might be missing? |
This sounds right. I'm not sure if you should need a new AliasesV3. But yes the general idea of pulling the JSON files in with download-repo-sources and then getting them into a canonicalizer data structure is correct. Thanks! |
In #218, we're adding locale canonicalization based upon CLDR json aliases.json data. This data is missing a handful of aliases that are defined in the bcp xml data. Once this data is added to json as tracked by #562, we'll be able to update the locale_canonicalizer to use these aliases as well.
This is blocked on both #218 and #562.
The text was updated successfully, but these errors were encountered: