Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

is_combining_mark() fails for U+11C3A #16

Closed
behnam opened this issue May 29, 2017 · 0 comments · Fixed by #17
Closed

is_combining_mark() fails for U+11C3A #16

behnam opened this issue May 29, 2017 · 0 comments · Fixed by #17

Comments

@behnam
Copy link
Contributor

behnam commented May 29, 2017

As noted in servo/rust-url#351, looks like there's a bug in this crate, causing assert!(is_combining_mark('\u{11C3A}')); to fail, although the character being a GC=Mn since Unicode 9.0: http://www.fileformat.info/info/unicode/char/11c3a/index.htm
@behnam behnam mentioned this issue May 29, 2017
Merged
behnam added a commit to behnam/rust-unicode-normalization that referenced this issue Jun 1, 2017
@behnam
Fix is_combining_mark table data
1e74c34 
* In `scripts/unicode.py`, the data used to generate `is_combining_mark()`
was being passed to the emit function incorrectly, resulting in the
table containing some other data instead. The script is fixed and new
`tables.rs` is generated.

* Add test for `is_combining_mark()` for ASCII chars, as well as a
couple of random chars based on the reported issue.

Fix unicode-rs#16
@behnam behnam mentioned this issue Jun 1, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix is_combining_mark table data behnam/rust-unicode-normalization
1 participant
@behnam