Switch from SmallVec to 100% safe TinyVec #54
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces uses of SmallVec with TinyVec, which is the same idea implemented in 100% safe code.
Performance is generally in line with SmallVec in this case, with some benchmarks being slightly slower and some slightly faster:
SmallVec 1.1.0
TinyVec 0.3.2
As you can see, e.g.
bench_is_nfd_stream_safe_normalized
andbench_nfkc_long
have improved whilebench_nfkd_long
andbench_nfc_ascii
have regressed, but none of the changes are dramatic.cargo test
passes, I haven't run any parametric or fuzz testing (not sure if this crate has any). TinyVec itself has been fuzz-tested for equivalence tostd::Vec
using arbitrary-model-tests framework.