travis: also test with minimum supported Rust version #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgeisler
force-pushed
the
travis-min-rust-version
branch
from
7f5045c
to
3d00c94
Compare
mgeisler
force-pushed
the
travis-min-rust-version
branch
from
3d00c94
to
b763059
Compare
The 1.2.0 release increased the minimum supported version of Rust from below 1.11.0 to 1.13.0 due to the introduction of code that use the "?" operator. This caused unexpected build failures in dependent crates, such as clap. This PR updates Travis to also test against the current minimum version. Changes to this version will thus fail PRs and it will become an active decision to bump the minimum supported Rust version. Between the commit was originally made and today, the minimum version increased further and the earliest version where I can get the crate to compile is now Rust 1.24.0. Fixes unicode-rs#26.
mgeisler
force-pushed
the
travis-min-rust-version
branch
from
b763059
to
7532142
Compare
|
@Manishearth, please take a look at this freshly rebased PR :-) |
|
I'm reluctant to guarantee a minimum supported version for this crate, but I don't mind adding it to the CI. |
|
Thanks, having it tested in CI is helpful! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 1.2.0 release increased the minimum supported version of Rust from
below 1.11.0 to 1.13.0 due to the introduction of code that use the
"?" operator. This caused unexpected build failures in dependent
crates, such as clap.
This PR updates Travis to also test against the current minimum
version. Changes to this version will thus fail PRs and it will become
an active decision to bump the minimum supported Rust version.
Between this PR was originally made and today, the minimum version
increased further and the earliest version where I can get the crate
to compile is now Rust 1.24.0.
Fixes #26.