Ensure that canonically equivalent strings have the same width #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, it was possible for the NFC and NFD forms of a string to be assigned different widths by this crate. This PR fixes that by marking all characters with
Grapheme_Extendas zero-width, and adds a test to make sure the property continues to hold.There are also 8 characters that we manually assign width 0 to. I think these should have been
Grapheme_Extendby UAX29's rules, because they NFD decompose to characters with the property; I've reported the issue to Unicode.Unfortunately,
width_cjk()continues not to be closed under canonical equivalence.