Add a possible issue to the README. #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
reviewed
Oct 11, 2018
| @@ -23,6 +23,16 @@ fn main() { | |||
| } | |||
| ``` | |||
|
|
|||
| **NOTE:** The computed width values may not match the actual rendered column | |||
| width. For example, the woman scientist emoji comprises of a woman emoji, a | |||
| zero-width joiner and a microscope emoji. | |||
There was a problem hiding this comment.
Probably mention that folks should refer to UTS 11 for more details on what this does and does not handle
Manishearth
reviewed
Oct 11, 2018
README.md
Outdated
|
|
||
| ```rust | ||
| extern crate unicode_width; | ||
| use unicode_width::UnicodeWidthStr::width; |
There was a problem hiding this comment.
This code doesn't compile, you can't import non-instance methods.
There was a problem hiding this comment.
Yeah, I can't get the rustdoc test to work locally for some reason, compiles now.
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes my "complaint" in issue #4 .