Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: expose ffi #1821

Closed
lockbox opened this issue Apr 6, 2023 · 5 comments
Closed

rust: expose ffi #1821

lockbox opened this issue Apr 6, 2023 · 5 comments

Comments

@lockbox
Copy link

lockbox commented Apr 6, 2023

the unicorn rust ffi is too high level for much customization, to enable an "opt-in" choice to more flexibility the ffi module should get re-exported public since there is no unicorn-sys create or equivalent etc.

@wtdcode
Copy link
Member

wtdcode commented Apr 11, 2023

Could you elaborate on your use case? I have the same thoughts for quite a long time.

@lockbox
Copy link
Author

lockbox commented Apr 11, 2023

What i did in https://github.com/lockbox/unicorn was expose the ffi layer. this allows you to make your own callbacks and pass custom user data a la ffi::uc_hook_add. My use case is wrapping unicorn with some tlc.

@wtdcode
Copy link
Member

wtdcode commented Apr 12, 2023

Okay, make sense. I'm actually writing some raw wrapper for these but still WIP... Mark as enhancement.

@lockbox
Copy link
Author

lockbox commented Apr 12, 2023

Cool! My changes I made work for me but are still a bit clunky. Looking forward to the changes

@lockbox
Copy link
Author

lockbox commented Aug 1, 2023

Closed in #1847

@lockbox lockbox closed this as completed Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants