Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UwU] Aria hidden elements must not be focusable or contain focusable elements. #784

Closed
dreyfus92 opened this issue Oct 5, 2023 · 1 comment

Comments

@dreyfus92
Copy link

dreyfus92 commented Oct 5, 2023

I'm not 100% sure on this one, it's noteworthy that elements with aria-hidden set to true typically should not be made focusable, nor should they contain focusable elements.

image

Here I share a couple of resources that talk about it:

This div is located here: https://unicorn-utterances-git-uwu-oceanbit.vercel.app/search?searchQuery=*&display=collections&filterTags=

@crutchcorn
Copy link
Member

crutchcorn commented Oct 8, 2023

This should be fixed in #790

Correction, I believe this is a false-positive as referenced by this issue: https://react-spectrum.adobe.com/react-aria/useSelect.html#false-positives

We're manually handling the focus states in order to have both a native select input experience but also a visually distinct one. Trying our hardest to avoid duplicating browser default behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants