[chore] add new async hook logic for modals #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgmarinho
reviewed
Jan 22, 2023
tgmarinho
suggested changes
Jan 22, 2023
tgmarinho
reviewed
Jan 22, 2023
|
run: and These commands above will help get some feedbacks ;) There are some imports not been used.
|
tgmarinho
suggested changes
Jan 22, 2023
|
What is this PR solving? It should be tested more. I couldn't do that. I only reviewed the code. |
|
Converting to draft, once we need to test it, also fix the conflicts. |
weeebr
changed the title
tgmarinho
reviewed
Feb 10, 2023
| @@ -154,6 +132,7 @@ export const AddApproveArbitrator = ({ | |||
| setAction("added"); | |||
| }) | |||
| .catch((e) => { | |||
| console.error(e); | |||
| return ( | ||
| <form ref={closeHandlerRef} autoComplete="off" onSubmit={handleSubmit}> | ||
| <ScopedModal | ||
| title={title} | ||
| body={ModalBody()} | ||
| footer={ModalFooter()} | ||
| body={<ModalBody />} |
| body={ModalBody()} | ||
| footer={ModalFooter()} | ||
| body={<ModalBody />} | ||
| footer={<ModalFooter />} |
…ed button state when loading
tgmarinho
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.