Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic when loading composite fonts #164

Merged
merged 2 commits into from Sep 7, 2019
Merged

Fix panic when loading composite fonts #164

merged 2 commits into from Sep 7, 2019

Conversation

adrg
Copy link
Collaborator

@adrg adrg commented Sep 6, 2019

Related to #87


This change is Reviewable

@codecov
Copy link

codecov bot commented Sep 6, 2019

Codecov Report

Merging #164 into development will increase coverage by 0.01%.
The diff coverage is 11.11%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #164      +/-   ##
===============================================
+ Coverage        57.54%   57.55%   +0.01%     
===============================================
  Files              189      189              
  Lines            34414    34412       -2     
===============================================
+ Hits             19802    19805       +3     
+ Misses           12067    12059       -8     
- Partials          2545     2548       +3
Impacted Files Coverage Δ
creator/styled_paragraph.go 87.5% <0%> (-0.59%) ⬇️
model/internal/fonts/ttfparser.go 68% <0%> (-0.31%) ⬇️
creator/paragraph.go 83.01% <25%> (-0.08%) ⬇️
model/font.go 57.11% <0%> (-0.36%) ⬇️
internal/textencoding/truetype.go 18% <0%> (+4%) ⬆️
internal/textencoding/encoder.go 26.47% <0%> (+26.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7406957...51b84ef. Read the comment docs.

Copy link
Contributor

@gunnsth gunnsth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants