Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FDF support for form fill rendering test #389

Merged
merged 1 commit into from Jul 3, 2020
Merged

Add FDF support for form fill rendering test #389

merged 1 commit into from Jul 3, 2020

Conversation

adrg
Copy link
Collaborator

@adrg adrg commented Jul 3, 2020

This change is Reviewable

@codecov
Copy link

codecov bot commented Jul 3, 2020

Codecov Report

Merging #389 into development will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #389      +/-   ##
===============================================
- Coverage        63.12%   63.08%   -0.04%     
===============================================
  Files              249      249              
  Lines            47251    47251              
===============================================
- Hits             29827    29809      -18     
+ Misses           16729    16727       -2     
- Partials           695      715      +20     
Impacted Files Coverage Δ
internal/e2etest/utils.go 70.00% <0.00%> (-10.00%) ⬇️
internal/jbig2/decoder/huffman/fixed_size_table.go 63.15% <0.00%> (-5.27%) ⬇️
model/optimize/image_ppi.go 73.84% <0.00%> (-1.54%) ⬇️
model/optimize/optimizer.go 87.14% <0.00%> (-1.43%) ⬇️
model/sighandler/sighandler_pkcs7.go 60.91% <0.00%> (-1.15%) ⬇️
model/signature_handler.go 70.27% <0.00%> (-0.91%) ⬇️
...ternal/jbig2/document/segments/halftone-segment.go 74.88% <0.00%> (-0.90%) ⬇️
ps/parser.go 80.67% <0.00%> (-0.85%) ⬇️
internal/jbig2/bitmap/blit.go 80.83% <0.00%> (-0.84%) ⬇️
internal/imageutil/rgbtobw.go 39.37% <0.00%> (-0.79%) ⬇️
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ca13a3...5b42309. Read the comment docs.

Copy link
Contributor

@gunnsth gunnsth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gunnsth gunnsth merged commit 42a3cfb into unidoc:development Jul 3, 2020
@adrg adrg deleted the render-test-form-fill-fdf branch July 8, 2020 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants