Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for empty encoded byte buffer on Flate decode #72

Merged
merged 1 commit into from Jun 3, 2019
Merged

Check for empty encoded byte buffer on Flate decode #72

merged 1 commit into from Jun 3, 2019

Conversation

adrg
Copy link
Collaborator

@adrg adrg commented Jun 3, 2019

Addreses #68

@codecov
Copy link

codecov bot commented Jun 3, 2019 •
edited

Codecov Report

Merging #72 into development will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development      #72      +/-   ##
===============================================
- Coverage        55.03%   55.02%   -0.01%     
===============================================
  Files              154      154              
  Lines            27972    27975       +3     
===============================================
  Hits             15393    15393              
- Misses           10758    10760       +2     
- Partials          1821     1822       +1
Impacted Files Coverage Δ
core/encoding.go 44.18% <0%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9d8725...bc58365. Read the comment docs.

gunnsth
gunnsth approved these changes Jun 3, 2019
View reviewed changes
Copy link
Contributor

@gunnsth gunnsth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gunnsth gunnsth added this to the v3.1.0 milestone Jun 3, 2019
@gunnsth gunnsth merged commit 9bc50d0 into unidoc:development Jun 3, 2019
@adrg adrg deleted the flate-encoder-empty-buffer branch June 10, 2019 17:16
@gunnsth gunnsth modified the milestones: v3.1.0, v3.0.2 Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gunnsth gunnsth gunnsth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adrg @gunnsth