Keep required plist files even if empty #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 6, 2016 12:49
I added a 'removeEmpty' keyword argument to `_normalizePlistFile` (default is `True`), and set it to False for "metainfo.plist", "glyphs/contents.plist", and "layercontents.plist" (UFO3). These plist files are required by to the specification, and should be kept even if they happen to be empty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_normalizePlistFilefunction currently deletes any plist files which happen to be empty, including files which are required by the UFO specification likecontents.plistorlayercontents.plist.This adds a 'removeEmpty' keyword argument to
_normalizePlistFile(default isTrue) and set it toFalsewhenever the empty plist file should be kept nonetheless.