always use Unix LF end of lines #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 7, 2016 13:56
Since we are writing output file in "text" mode, by default Python uses
the native `os.linesep`, which on Windows is CRLF ("\r\n").
We want all line endings to be normalized as Unix line feeds.
By passing a `newline="\n"` argument to `io.open`, we make sure this is
the case on every platform, including Windows.
|
BTW, the Appveyor build did not start automatically -- and actually that was the most important one to check since this patch is kind of Windows specific... (the tests do pass on my local Windows machine). On the front page of ufoNormalizer, the Appveyor badge is pointing to an Appveyor account owned by @miguelsousa: https://ci.appveyor.com/project/miguelsousa/ufonormalizer/history Maybe it needs to be @typesupply who needs to set up Appveyor for this repo? I'm not sure... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are writing files in "text" mode, by default Python uses the native
os.linesep, which on Windows is CR+LF ("\r\n").We want all line endings to be normalized as Unix line feeds. By passing a
newline="\n"argument toio.open, we make sure this is the case on every platform, including Windows./cc @moyogo