Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GLIF plist loading: Do not escape strings and keys when loading #51

Merged
merged 1 commit into from Dec 17, 2018
Merged

GLIF plist loading: Do not escape strings and keys when loading #51

merged 1 commit into from Dec 17, 2018

Conversation

madig
Copy link
Contributor

@madig madig commented Dec 17, 2018

etree unescapes for us. This avoids double-escaping &, < and >. The XML writer escapes them again.

@madig
GLIF plist loading: Do not escape strings and keys when loading
1953c8f 
etree unescapes for us. This avoids double-escaping  `&`, `<` and `>`.
anthrotype
anthrotype approved these changes Dec 17, 2018
View reviewed changes
Copy link
Member

@anthrotype anthrotype left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

I wonder why was the ufonormalizer even attempting to "escape" strings and keys upon loading. If anything it should have un-escaped them -- but that's unnecessary given etree does it for us.

@madig
Copy link
Contributor Author

madig commented Dec 17, 2018

ab56841

No reason given. Oh well.

@anthrotype anthrotype merged commit a7a91d3 into unified-font-object:master Dec 17, 2018
@madig madig deleted the unescape-strings-on-load branch December 17, 2018 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthrotype anthrotype anthrotype approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@madig @anthrotype