Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to global or bundled remark version #31

Closed
4 tasks done
bennypowers opened this issue Feb 1, 2022 · 4 comments
Closed
4 tasks done

Fallback to global or bundled remark version #31

bennypowers opened this issue Feb 1, 2022 · 4 comments
Labels
🤷 no/invalid This cannot be acted upon 👎 phase/no Post cannot or will not be acted on

Comments

@bennypowers
Copy link

Initial checklist

Problem

A user wishes to use unified-language-server or remark-language-server without installing remark in their local project folder

Solution

unified-language-server should fall back to a global or bundled installation of remark if a local one is not found

Alternatives

installing remark locally solely for the sake of a specific class of editors is not ideal

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Feb 1, 2022
@wooorm
Copy link
Member

wooorm commented Feb 1, 2022

This project allows that. Pass defaultProcessor.

@wooorm wooorm added 👎 phase/no Post cannot or will not be acted on 🤷 no/invalid This cannot be acted upon labels Feb 1, 2022
@wooorm wooorm closed this as completed Feb 1, 2022
@remcohaszing
Copy link
Member

Yes, this project allows that, but remark-language-server doesn’t use it.

I’m curious to the scenario. Why does this user wish to use remark-language-server without installing remark in their local project folder?

I could imagine a number of scenarios, e.g.: Does the project use remark or remark-cli? Does the user want to use remark-language-server, but doesn’t the project use remark? Does the project use pnpm?

@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Feb 1, 2022
@bennypowers
Copy link
Author

Here's one scenario, which I imagine is probably very common:

  • The repo contains markdown files
  • The repo does not use remark in any of it's app code or dependencies
  • The user wants to format markdown files in the repo
  • The user does not want to install any extra dependencies

@bennypowers
Copy link
Author

At the moment, neovim users who follow the docs all the way down the rabbit hole, and end up installing the remark server, are going to get this error notification on every. single. character. they. type. in. a. markdown. file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤷 no/invalid This cannot be acted upon 👎 phase/no Post cannot or will not be acted on
Development

No branches or pull requests

3 participants