Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dialog strings translateable #57

Closed
connyduck opened this issue Aug 15, 2022 · 2 comments
Closed

Make dialog strings translateable #57

connyduck opened this issue Aug 15, 2022 · 2 comments

Comments

@connyduck
Copy link
Contributor

Currently the text displayed to users in dialogs is hardcoded. It would be cool if they were Android string resources so client apps can override them and/or provide additional translations. Ideally the connector already comes with translations in common languages.

@p1gp1g
Copy link
Member

p1gp1g commented Aug 19, 2022

Dialog strings can be overridden with the optional param registrationDialogContent.

Check the documentation to use it (java or kotlin) : https://unifiedpush.org/developers/android/

Params are here : https://github.com/UnifiedPush/android-connector/blob/main/connector/src/main/java/org/unifiedpush/android/connector/RegistrationDialogContent.kt

I'm closing this issue since the text can be overridden and translated :)

@p1gp1g p1gp1g closed this as completed Aug 19, 2022
@p1gp1g
Copy link
Member

p1gp1g commented Aug 19, 2022

Note that suggestions to improve this are welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants