Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terraform 0.12 support #44

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Terraform 0.12 support #44

wants to merge 23 commits into from

Conversation

disaac
Copy link
Member

@disaac disaac commented Sep 21, 2019

Module updates for terraform 0.12 support

akatrevorjay and others added 17 commits May 2, 2019 15:04
This reverts commit 74c36ccd05fb038db21983517cbb64f8d54e252f.
[DEVOPS-2273] Static subnet support
This reverts commit 54768d6.
* Added .env.covalence for local testing outside circleci
* Updated hiera to use alias instead hiera.
* Updated Version in changelog to 0.4.0 for TF v0.12 upgrade listed incompatibilities.
* Removed TF 11 version constraint from module since it is defined in versions.tf file.
* Ran bin/covalence all:format to format all of the TF files after updates.
* Set types to bool for TF 12 support in ci.
* Updated README to reflect true default of enable_dns_hostnames which uses the module variable enable_hostnames. The true default is false.
* Updated examples to properly use the order of opperations to multiple the returned value by the nat_gateways_enabled variable. After automated conversion to support terraform 0.12 the total was not being multiplied by the return of the signum of the nat_gateways_enabled check in count.
* Updated the state bucket to use a new state bucket created in the unifio uat aws account.
* Updated the region to be us-east-1 since its in a new account.
* Updated boolean flag values to be converted to true boolean or null if empty string provided. Allows default behavior but uses a local variable instead of the supplied module variable. `var.enable_dns` `var.enable_hostnames` `var.enable_classiclink`  `enable_dmz_public_ips` . Prior to update ci tests would fail due to the bool values being expected.
* Updated the container used to the most recent automated build of dockerfile-ci
@disaac disaac requested a review from sdmikey October 9, 2019 01:50
@disaac disaac self-assigned this Oct 9, 2019
* Added local definitions for variables that are interpreted as bools by resources.
* Check for empty values and set to null when empty or convert string bool when not empty.
* removing the quotes grom count result so that count functions properly.
* Updated the covalence ci image to the latest which uses Terraform 0.12.29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants