Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Conj instance method to Jax Frontend #14541

Merged
merged 2 commits into from
Apr 25, 2023

Conversation

RakshitKumar04
Copy link
Contributor

@RakshitKumar04 RakshitKumar04 commented Apr 24, 2023

Close #14167

@RakshitKumar04
Copy link
Contributor Author

Close #14167

@RakshitKumar04
Copy link
Contributor Author

Hey, @hirwa-nshuti please review the PR.

@ivy-leaves ivy-leaves added the JAX Frontend Developing the JAX Frontend, checklist triggered by commenting add_frontend_checklist label Apr 24, 2023
Copy link
Contributor

@fnhirwa fnhirwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @RakshitKumar04
Thanks for the PR😊

Just a small change is needed I'll merge the PR after.
Thanks

@RakshitKumar04
Copy link
Contributor Author

Hey @hirwa-nshuti changed the dtype, please take a look.

Copy link
Contributor

@fnhirwa fnhirwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great🙂

Going to merge!

@fnhirwa fnhirwa merged commit 92ea4fb into ivy-llc:master Apr 25, 2023
@RakshitKumar04 RakshitKumar04 deleted the jax-instMeth-conj branch June 20, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JAX Frontend Developing the JAX Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

conj
3 participants