Work Around Request Size #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Login in Entra is causing the request size to be blown due to large tokens, probably hinting they encode permissions in there rather thand doing a DB lookup. As a quick hack, remove the tokens from the code and our tokens to reduce the size, as they aren't necessary. A long term solution will be to save these details in a DB and pass around much smaller identifiers to allow a lookup. We need the DB anyway for access token single use and revocaction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Login in Entra is causing the request size to be blown due to large tokens, probably hinting they encode permissions in there rather thand doing a DB lookup. As a quick hack, remove the tokens from the code and our tokens to reduce the size, as they aren't necessary. A long term solution will be to save these details in a DB and pass around much smaller identifiers to allow a lookup. We need the DB anyway for access token single use and revocaction.