Add default configuration file #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanJum
force-pushed
the
StefanJum/add-config-files
branch
from
f7553e9
to
df1e8e7
Compare
razvand
requested changes
Jul 11, 2023
There was a problem hiding this comment.
This looks good.
Please also add a commit that updates the README.md file with detailed instructions, similar with the README.md of app-helloworld, including the TLDR instructions. Leave out KraftKit.
Corresponding contents from this PR would be moved as part of the README.md file, and keep a reference to it.
Similar to what we have in other applications, add a default minimal config file that can be used by `make defconfig` to generate a proper full configuration. Also update the Makefile to match the new directory layout. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com>
Update the .gitignore to ignore the .unikraft/ directory, which is the output of the setup stage. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com>
StefanJum
force-pushed
the
StefanJum/add-config-files
branch
from
df1e8e7
to
304cc10
Compare
|
Done @razvand. Since this is an application with a more advanced purpose, and basic users will just use the pre-built elfloader images, I left the running / debugging instructions in the |
razvand
requested changes
Jul 11, 2023
Update the `REAMDE.md` file with instructions on how to setup, configure and build the `app-elfloader`, using the already provided minimal configuration file. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com>
StefanJum
force-pushed
the
StefanJum/add-config-files
branch
from
304cc10
to
3de89de
Compare
|
Done @razvand |
razvand
approved these changes
Jul 11, 2023
There was a problem hiding this comment.
Reviewed-by: Razvan Deaconescu razvand@unikraft.io
Approved-by: Razvan Deaconescu razvand@unikraft.io
unikraft-bot
pushed a commit
that referenced
this pull request
Jul 11, 2023
Update the .gitignore to ignore the .unikraft/ directory, which is the output of the setup stage. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com> Reviewed-by: Razvan Deaconescu <razvand@unikraft.io> Approved-by: Razvan Deaconescu <razvand@unikraft.io> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: #22
unikraft-bot
pushed a commit
that referenced
this pull request
Jul 11, 2023
Update the `REAMDE.md` file with instructions on how to setup, configure and build the `app-elfloader`, using the already provided minimal configuration file. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com> Reviewed-by: Razvan Deaconescu <razvand@unikraft.io> Approved-by: Razvan Deaconescu <razvand@unikraft.io> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: #22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.