Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for openssl to run.yaml #52

Merged
merged 1 commit into from Oct 20, 2023

Conversation

sinamhdv
Copy link
Contributor

added openssl to run.yaml, which currently performs sha256 on a sample input file.

Copy link
Member

@StefanJum StefanJum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sinamhdv please wrapt the commit description at ~70 characters per line. Looks good besides that.

@razvand
Copy link
Contributor

razvand commented Sep 25, 2023

The generated run script gives out:

[    0.261271] ERR:  [appelfloader] <elf_load.c @  135> openssl: ELF executable is not position-independent!                                                                                                                                  
[    0.262257] ERR:  [appelfloader] <elf_load.c @  703> openssl: Parsing of ELF image failed: Exec format error (-8)

To fix that, you need to update the command option with: /lib64/ld-linux-x86-64.so.2 --library-path /lib /bin/openssl sha256 < input.txt

@razvand
Copy link
Contributor

razvand commented Sep 25, 2023

The generated run script gives out:

[    0.261271] ERR:  [appelfloader] <elf_load.c @  135> openssl: ELF executable is not position-independent!                                                                                                                                  
[    0.262257] ERR:  [appelfloader] <elf_load.c @  703> openssl: Parsing of ELF image failed: Exec format error (-8)

To fix that, you need to update the command option with: /lib64/ld-linux-x86-64.so.2 --library-path /lib /bin/openssl sha256 < input.txt

This is actually solved by this PR: unikraft/dynamic-apps#95

Aim for this to get merged and that will probably solve this.

Add OpenSSL runtime configuration to `run.yaml`. It currently outputs
the SHA256 digest on a sample input file.

Signed-off-by: Sina Mahdavi <sinamhdv@gmail.com>
@razvand razvand self-assigned this Oct 20, 2023
@razvand razvand added enhancement New feature or request kind/hackathon labels Oct 20, 2023
@razvand razvand changed the base branch from stable to staging October 20, 2023 20:39
Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Razvan Deaconescu razvand@unikraft.io
Approved-by: Razvan Deaconescu razvand@unikraft.io

@razvand razvand merged commit 188dc48 into unikraft:staging Oct 20, 2023
razvand pushed a commit that referenced this pull request Oct 20, 2023
Add OpenSSL runtime configuration to `run.yaml`. It currently outputs
the SHA256 digest on a sample input file.

Signed-off-by: Sina Mahdavi <sinamhdv@gmail.com>
Reviewed-by: Razvan Deaconescu <razvand@unikraft.io>
Approved-by: Razvan Deaconescu <razvand@unikraft.io>
GitHub-Closes: #52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request kind/hackathon
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants