This repository has been archived by the owner on Mar 4, 2024. It is now read-only.
Stefan jum/add dev content #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
razvand
suggested changes
Sep 24, 2023
There was a problem hiding this comment.
Please also add an update to the README.md file. See the updates from this commit.
StefanJum
force-pushed
the
StefanJum/add-dev-content
branch
from
79c42ba
to
7334814
Compare
|
Done @razvand |
StefanJum
force-pushed
the
StefanJum/add-dev-content
branch
from
7334814
to
e2174c3
Compare
razvand
suggested changes
Sep 30, 2023
StefanJum
force-pushed
the
StefanJum/add-dev-content
branch
from
e2174c3
to
a9e2425
Compare
StefanJum
force-pushed
the
StefanJum/add-dev-content
branch
4 times, most recently
from
d32290e
to
fdb4ce7
Compare
Only use QEMU and Firecracker as targets. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com>
`.unikraft/` was previously used as the directory to clone library repositories (including the `unikraft` core repository). Being a hidden directory, it is not immediately available to the developer. Use `workdir/` instead. Also use `workdir/build/` as output directory and ignore the `workdir/` directory. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com>
Move all the defconfig files into the `defconfigs/` directory. Also minimise them using `make savedefconfig`, removing all unnecesary config options. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com>
The `generate.py` script will be downloaded from and used to generate the scripts in the `scripts/build/` and `scripts/run/` directories. This will improve maintenance (only required to happen for the `generate.py` script), while still keeping things usable by providing the basic build and run scripts. The `setup.sh` script will clone all dependencies in the `workdir/` directory. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com>
Add instructions on how to use the generator script and the output scripts to build and run the application. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com>
Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com>
razvand
force-pushed
the
StefanJum/add-dev-content
branch
from
fdb4ce7
to
2a7a4ae
Compare
razvand
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
Reviewed-by: Razvan Deaconescu razvand@unikraft.io
Approved-by: Razvan Deaconescu razvand@unikraft.io
razvand
pushed a commit
that referenced
this pull request
Oct 3, 2023
Only use QEMU and Firecracker as targets. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com> Reviewed-by: Razvan Deaconescu <razvand@unikraft.io> Approved-by: Razvan Deaconescu <razvand@unikraft.io> GitHub-Closes: #21
razvand
pushed a commit
that referenced
this pull request
Oct 3, 2023
`.unikraft/` was previously used as the directory to clone library repositories (including the `unikraft` core repository). Being a hidden directory, it is not immediately available to the developer. Use `workdir/` instead. Also use `workdir/build/` as output directory and ignore the `workdir/` directory. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com> Reviewed-by: Razvan Deaconescu <razvand@unikraft.io> Approved-by: Razvan Deaconescu <razvand@unikraft.io> GitHub-Closes: #21
razvand
pushed a commit
that referenced
this pull request
Oct 3, 2023
Move all the defconfig files into the `defconfigs/` directory. Also minimise them using `make savedefconfig`, removing all unnecesary config options. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com> Reviewed-by: Razvan Deaconescu <razvand@unikraft.io> Approved-by: Razvan Deaconescu <razvand@unikraft.io> GitHub-Closes: #21
razvand
pushed a commit
that referenced
this pull request
Oct 3, 2023
The `generate.py` script will be downloaded from and used to generate the scripts in the `scripts/build/` and `scripts/run/` directories. This will improve maintenance (only required to happen for the `generate.py` script), while still keeping things usable by providing the basic build and run scripts. The `setup.sh` script will clone all dependencies in the `workdir/` directory. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com> Reviewed-by: Razvan Deaconescu <razvand@unikraft.io> Approved-by: Razvan Deaconescu <razvand@unikraft.io> GitHub-Closes: #21
razvand
pushed a commit
that referenced
this pull request
Oct 3, 2023
Add instructions on how to use the generator script and the output scripts to build and run the application. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com> Reviewed-by: Razvan Deaconescu <razvand@unikraft.io> Approved-by: Razvan Deaconescu <razvand@unikraft.io> GitHub-Closes: #21
razvand
pushed a commit
that referenced
this pull request
Oct 3, 2023
Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com> Reviewed-by: Razvan Deaconescu <razvand@unikraft.io> Approved-by: Razvan Deaconescu <razvand@unikraft.io> GitHub-Closes: #21
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.