This repository has been archived by the owner on Mar 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 40
Stefan jum/add dev content #25
Merged
razvand
merged 6 commits into
unikraft:staging
from
unikraft-upb:StefanJum/add-dev-content
Oct 3, 2023
Merged
Stefan jum/add dev content #25
razvand
merged 6 commits into
unikraft:staging
from
unikraft-upb:StefanJum/add-dev-content
Oct 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please also add an update to the |
`.unikraft/` was previously used as the directory to clone library repositories (including the `unikraft` core repository). Being a hidden directory, it is not immediately available to the developer. Use `workdir/` instead. Also use `workdir/build/` as output directory and ignore the `workdir/` directory. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com>
0af9d3e
to
45c6f41
Compare
Done @razvand |
45c6f41
to
a459405
Compare
razvand
suggested changes
Sep 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the generate.py
script, since it's now downloaded. Also ignore it.
Also update the TLDR with the downloading and using of |
a459405
to
998e708
Compare
4034f60
to
7c2106f
Compare
Move all the defconfig files into the `defconfigs/` directory. Also minimise them using `make savedefconfig`, removing all unnecesary config options. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com>
The `generate.py` script will be downloaded from https://raw.githubusercontent.com/unikraft/app-testing/staging/scripts/generate.py and used to generate the scripts in the `scripts/build/` and `scripts/run/` directories. This will improve maintenance (only required to happen for the `generate.py` script), while still keeping things usable by providing the basic build and run scripts. Use the `setup.sh` script will clone all the dependencies in the `workdir` repository. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com>
Add instructions on using the generate script and the scripts that will result from that for building and running the application. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com>
Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com>
Only keep `qemu` and `firecracker` targets in `kraft.yaml`. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com>
cac1d32
to
803427d
Compare
razvand
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed-by: Razvan Deaconescu razvand@unikraft.io
Approved-by: Razvan Deaconescu razvand@unikraft.io
razvand
pushed a commit
that referenced
this pull request
Oct 3, 2023
`.unikraft/` was previously used as the directory to clone library repositories (including the `unikraft` core repository). Being a hidden directory, it is not immediately available to the developer. Use `workdir/` instead. Also use `workdir/build/` as output directory and ignore the `workdir/` directory. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com> Reviewed-by: Razvan Deaconescu <razvand@unikraft.io> Approved-by: Razvan Deaconescu <razvand@unikraft.io> GitHub-Closes: #25
razvand
pushed a commit
that referenced
this pull request
Oct 3, 2023
Move all the defconfig files into the `defconfigs/` directory. Also minimise them using `make savedefconfig`, removing all unnecesary config options. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com> Reviewed-by: Razvan Deaconescu <razvand@unikraft.io> Approved-by: Razvan Deaconescu <razvand@unikraft.io> GitHub-Closes: #25
razvand
pushed a commit
that referenced
this pull request
Oct 3, 2023
The `generate.py` script will be downloaded from https://raw.githubusercontent.com/unikraft/app-testing/staging/scripts/generate.py and used to generate the scripts in the `scripts/build/` and `scripts/run/` directories. This will improve maintenance (only required to happen for the `generate.py` script), while still keeping things usable by providing the basic build and run scripts. Use the `setup.sh` script will clone all the dependencies in the `workdir` repository. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com> Reviewed-by: Razvan Deaconescu <razvand@unikraft.io> Approved-by: Razvan Deaconescu <razvand@unikraft.io> GitHub-Closes: #25
razvand
pushed a commit
that referenced
this pull request
Oct 3, 2023
Add instructions on using the generate script and the scripts that will result from that for building and running the application. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com> Reviewed-by: Razvan Deaconescu <razvand@unikraft.io> Approved-by: Razvan Deaconescu <razvand@unikraft.io> GitHub-Closes: #25
razvand
pushed a commit
that referenced
this pull request
Oct 3, 2023
Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com> Reviewed-by: Razvan Deaconescu <razvand@unikraft.io> Approved-by: Razvan Deaconescu <razvand@unikraft.io> GitHub-Closes: #25
razvand
pushed a commit
that referenced
this pull request
Oct 3, 2023
Only keep `qemu` and `firecracker` targets in `kraft.yaml`. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com> Reviewed-by: Razvan Deaconescu <razvand@unikraft.io> Approved-by: Razvan Deaconescu <razvand@unikraft.io> GitHub-Closes: #25
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.