This repository has been archived by the owner on Mar 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 13
Update README.md file with easier to use instructions #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b3236ef
to
a8a69c5
Compare
razvand
suggested changes
Jul 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @StefanJum. Let's use the direct qemu-system-...
command, not the full path.
Also, add back the run-qemu-...
scripts that create the bridges behind the scenes.
a8a69c5
to
30e3ed6
Compare
Done @razvand |
razvand
suggested changes
Jul 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@StefanJum, just some minor changes. Then we can approve it.
30e3ed6
to
b0661a4
Compare
Done @razvand |
Rename the `config-*` files and add a `TLDR` section that summarises the setup. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com>
b0661a4
to
8d23efe
Compare
razvand
approved these changes
Jul 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed-by: Razvan Deaconescu razvand@unikraft.io
Approved-by: Razvan Deaconescu razvand@unikraft.io
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
ci/merged
documentation
Improvements or additions to documentation
enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will remove the running scripts and add the commands in the README file, rename the
config-*
files and add aTLDR
section that summarises the setup.