This repository has been archived by the owner on Mar 2, 2024. It is now read-only.
Stefan jum/add dev content #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`.unikraft/` was previously used as the directory to clone library repositories (including the `unikraft` core repository). Being a hidden directory, it is not immediately available to the developer. Use `workdir/` instead. Also use `workdir/build/` as output directory and ignore the `workdir/` directory. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com>
|
Please also add an update to the Also update |
Move all the defconfig files into the `defconfigs/` directory. Also minimise them using `make savedefconfig`, removing all unnecesary config options. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com>
StefanJum
force-pushed
the
StefanJum/add-dev-content
branch
from
7e8e5de
to
915771e
Compare
|
Done @razvand |
StefanJum
force-pushed
the
StefanJum/add-dev-content
branch
from
915771e
to
862b62b
Compare
razvand
suggested changes
Oct 1, 2023
StefanJum
force-pushed
the
StefanJum/add-dev-content
branch
from
862b62b
to
0806690
Compare
StefanJum
force-pushed
the
StefanJum/add-dev-content
branch
3 times, most recently
from
23a6812
to
304daf0
Compare
The `generate.py` script will be downloaded from https://raw.githubusercontent.com/unikraft/app-testing/staging/scripts/generate.py -O scripts/generate.py and will be used to generate the scripts in the `scripts/build/` and `scripts/run/` directories. This will improve maintenance (only required to happen for the `generate.py` script), while still keeping things usable by providing the basic build and run scripts. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com>
StefanJum
force-pushed
the
StefanJum/add-dev-content
branch
2 times, most recently
from
d0c304d
to
811b0ad
Compare
Add instructions on how to use the generator script and the output scripts to build and run the application. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com>
Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com>
razvand
force-pushed
the
StefanJum/add-dev-content
branch
from
811b0ad
to
e7ac97e
Compare
razvand
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
Reviewed-by: Razvan Deaconescu razvand@unikraft.io
Approved-by: Razvan Deaconescu razvand@unikraft.io
razvand
pushed a commit
that referenced
this pull request
Oct 3, 2023
`.unikraft/` was previously used as the directory to clone library repositories (including the `unikraft` core repository). Being a hidden directory, it is not immediately available to the developer. Use `workdir/` instead. Also use `workdir/build/` as output directory and ignore the `workdir/` directory. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com> Reviewed-by: Razvan Deaconescu <razvand@unikraft.io> Approved-by: Razvan Deaconescu <razvand@unikraft.io> GitHub-Closes: #12
razvand
pushed a commit
that referenced
this pull request
Oct 3, 2023
Move all the defconfig files into the `defconfigs/` directory. Also minimise them using `make savedefconfig`, removing all unnecesary config options. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com> Reviewed-by: Razvan Deaconescu <razvand@unikraft.io> Approved-by: Razvan Deaconescu <razvand@unikraft.io> GitHub-Closes: #12
razvand
pushed a commit
that referenced
this pull request
Oct 3, 2023
The `generate.py` script will be downloaded from https://raw.githubusercontent.com/unikraft/app-testing/staging/scripts/generate.py -O scripts/generate.py and will be used to generate the scripts in the `scripts/build/` and `scripts/run/` directories. This will improve maintenance (only required to happen for the `generate.py` script), while still keeping things usable by providing the basic build and run scripts. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com> Reviewed-by: Razvan Deaconescu <razvand@unikraft.io> Approved-by: Razvan Deaconescu <razvand@unikraft.io> GitHub-Closes: #12
razvand
pushed a commit
that referenced
this pull request
Oct 3, 2023
Add instructions on how to use the generator script and the output scripts to build and run the application. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com> Reviewed-by: Razvan Deaconescu <razvand@unikraft.io> Approved-by: Razvan Deaconescu <razvand@unikraft.io> GitHub-Closes: #12
razvand
pushed a commit
that referenced
this pull request
Oct 3, 2023
Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com> Reviewed-by: Razvan Deaconescu <razvand@unikraft.io> Approved-by: Razvan Deaconescu <razvand@unikraft.io> GitHub-Closes: #12
razvand
pushed a commit
that referenced
this pull request
Oct 3, 2023
Switch to using fs1 as 9pfs id in `kraft.yaml`. This makes it compatible with KraftKit handling of 9pfs mounts. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com> Reviewed-by: Razvan Deaconescu <razvand@unikraft.io> Approved-by: Razvan Deaconescu <razvand@unikraft.io> GitHub-Closes: #12
razvand
pushed a commit
that referenced
this pull request
Oct 3, 2023
Switch to using fs1 as 9pfs id in `kraft.yaml`. This makes it compatible with KraftKit handling of 9pfs mounts. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com> Reviewed-by: Razvan Deaconescu <razvand@unikraft.io> Approved-by: Razvan Deaconescu <razvand@unikraft.io> GitHub-Closes: #12
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.