-
Notifications
You must be signed in to change notification settings - Fork 16
Add Makefile, configuration files and scripts #13
Add Makefile, configuration files and scripts #13
Conversation
6447d80
to
5ba0260
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@razvand first round
6557790
to
2fdb71a
Compare
2fdb71a
to
36fbcad
Compare
36fbcad
to
626c31f
Compare
8c6de1a
to
a4bbc4b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine besides the comment
a4bbc4b
to
ae5d80f
Compare
Update the README with instructions on setting up, configuring, building and running the Nginx app with Unikraft. As part of it, add Makefile files, configuration files and scripts; they are referenced in the `README.md` file. Current instructions cover the use of QEMU/KVM platform (both on x86_64 and on AArch64) and GCC. Firecraker/KVM, Xen, Linux platforms and Clang are not yet documented. Signed-off-by: Razvan Deaconescu <razvand@unikraft.io>
Ignore files and folder that are output from the set up, configure, build or run steps. Signed-off-by: Razvan Deaconescu <razvand@unikraft.io>
ae5d80f
to
dc3235f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, thanks.
Reviewed-by: Stefan Jumarea stefanjumarea02@gmail.com
Approved-by: Stefan Jumarea stefanjumarea02@gmail.com
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good!
Reviewed-by: Ioan-Teodor Teugea ioan_teodor.teugea@stud.acs.upb.ro
Ignore files and folder that are output from the set up, configure, build or run steps. Signed-off-by: Razvan Deaconescu <razvand@unikraft.io> Reviewed-by: Stefan Jumarea <stefanjumarea02@gmail.com> Approved-by: Stefan Jumarea <stefanjumarea02@gmail.com> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: #13
Update the README with instructions on setting up, configuring, building and running the Nginx app with Unikraft. As part of it, add Makefile files, configuration files and scripts; they are referenced in the
README.md
file.Current instructions cover the use of QEMU/KVM platform (both on x86_64 and on AArch64) and GCC. Firecraker/KVM, Xen, Linux platforms and Clang are not yet documented.