Skip to content
This repository has been archived by the owner on Mar 4, 2024. It is now read-only.

Add Makefile, configuration files and scripts #13

Closed

Conversation

razvand
Copy link
Contributor

@razvand razvand commented Jul 1, 2023

Update the README with instructions on setting up, configuring, building and running the Nginx app with Unikraft. As part of it, add Makefile files, configuration files and scripts; they are referenced in the README.md file.

Current instructions cover the use of QEMU/KVM platform (both on x86_64 and on AArch64) and GCC. Firecraker/KVM, Xen, Linux platforms and Clang are not yet documented.

@razvand razvand added the enhancement New feature or request label Jul 1, 2023
@razvand razvand force-pushed the add-readme-makefile-scripts branch from 6447d80 to 5ba0260 Compare July 1, 2023 11:43
Copy link
Member

@StefanJum StefanJum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@razvand first round

config-qemu-x86_x64 Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@razvand razvand force-pushed the add-readme-makefile-scripts branch 2 times, most recently from 6557790 to 2fdb71a Compare July 1, 2023 12:00
run-qemu-aarch64.sh Outdated Show resolved Hide resolved
@razvand razvand force-pushed the add-readme-makefile-scripts branch from 2fdb71a to 36fbcad Compare July 1, 2023 12:34
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
fs0/nginx/logs/.gitignore Outdated Show resolved Hide resolved
@razvand razvand force-pushed the add-readme-makefile-scripts branch from 36fbcad to 626c31f Compare July 1, 2023 12:54
@razvand razvand requested a review from StefanJum July 1, 2023 12:56
@razvand razvand force-pushed the add-readme-makefile-scripts branch 4 times, most recently from 8c6de1a to a4bbc4b Compare July 1, 2023 13:11
Copy link
Member

@StefanJum StefanJum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine besides the comment

README.md Outdated Show resolved Hide resolved
@razvand razvand force-pushed the add-readme-makefile-scripts branch from a4bbc4b to ae5d80f Compare July 1, 2023 13:17
Update the README with instructions on setting up, configuring, building
and running the Nginx app with Unikraft. As part of it, add Makefile
files, configuration files and scripts; they are referenced in the
`README.md` file.

Current instructions cover the use of QEMU/KVM platform (both on x86_64 and
on AArch64) and GCC. Firecraker/KVM, Xen, Linux platforms and Clang are
not yet documented.

Signed-off-by: Razvan Deaconescu <razvand@unikraft.io>
Ignore files and folder that are output from the set up, configure,
build or run steps.

Signed-off-by: Razvan Deaconescu <razvand@unikraft.io>
@razvand razvand force-pushed the add-readme-makefile-scripts branch from ae5d80f to dc3235f Compare July 1, 2023 13:24
@razvand razvand requested a review from StefanJum July 1, 2023 13:28
Copy link
Member

@StefanJum StefanJum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thanks.

Reviewed-by: Stefan Jumarea stefanjumarea02@gmail.com
Approved-by: Stefan Jumarea stefanjumarea02@gmail.com

Copy link

@John-Ted John-Ted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

Reviewed-by: Ioan-Teodor Teugea ioan_teodor.teugea@stud.acs.upb.ro

unikraft-bot pushed a commit that referenced this pull request Jul 1, 2023
Ignore files and folder that are output from the set up, configure,
build or run steps.

Signed-off-by: Razvan Deaconescu <razvand@unikraft.io>
Reviewed-by: Stefan Jumarea <stefanjumarea02@gmail.com>
Approved-by: Stefan Jumarea <stefanjumarea02@gmail.com>
Tested-by: Unikraft CI <monkey@unikraft.io>
GitHub-Closes: #13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ci/merged enhancement New feature or request
Projects
Status: Done!
Development

Successfully merging this pull request may close these issues.

None yet

4 participants