Add Makefile, configuration files and scripts #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanJum
force-pushed
the
StefanJum/update-app-docs
branch
from
4f31315
to
f45e476
Compare
John-Ted
approved these changes
Jul 1, 2023
There was a problem hiding this comment.
Reviewed-by: Ioan-Teodor Teugea ioan_teodor.teugea@stud.acs.upb.ro
This was referenced Jul 1, 2023
razvand
requested changes
Jul 1, 2023
There was a problem hiding this comment.
@StefanJum, see my comments. I would also do a commit to rename minrootfs.tgz to rootfs.tar.gz. The .tgz extension is weird. And no reason to confuse people about the min part in minrootfs.
StefanJum
force-pushed
the
StefanJum/update-app-docs
branch
from
f45e476
to
69c267a
Compare
Ignore files and folder that are output from the set up, configure, build or run steps. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com>
Rename the filesystem archive to `rootfs.tar.gz`, since it is more explicit. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com>
Update platform name from `kvm` to `qemu`, since the default naming convention was changed in release 0.13.0. Also update the rootfs name, from `./minrootfs.tgz` to `./rootfs.tar.gz`. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com>
StefanJum
force-pushed
the
StefanJum/update-app-docs
branch
from
69c267a
to
94f7482
Compare
razvand
requested changes
Jul 1, 2023
StefanJum
force-pushed
the
StefanJum/update-app-docs
branch
from
94f7482
to
d56b249
Compare
Update the README with instructions on setting up, configuring, building and running the Python3 app with Unikraft. As part of it, add Makefile files, configuration files and scripts; they are referenced in the `README.md` file. Current instructions cover the use of QEMU/KVM platform (both on x86_64 and on AArch64) and GCC. Firecraker/KVM, Xen, Linux platforms and Clang are not yet documented. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com>
StefanJum
force-pushed
the
StefanJum/update-app-docs
branch
from
d56b249
to
f50987b
Compare
razvand
approved these changes
Jul 1, 2023
There was a problem hiding this comment.
Reviewed-by: Razvan Deaconescu razvand@unikraft.io
Approved-by: Razvan Deaconescu razvand@unikraft.io
unikraft-bot
pushed a commit
that referenced
this pull request
Jul 1, 2023
Rename the filesystem archive to `rootfs.tar.gz`, since it is more explicit. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com> Reviewed-by: Razvan Deaconescu <razvand@unikraft.io> Approved-by: Razvan Deaconescu <razvand@unikraft.io> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: #12
unikraft-bot
pushed a commit
that referenced
this pull request
Jul 1, 2023
Update platform name from `kvm` to `qemu`, since the default naming convention was changed in release 0.13.0. Also update the rootfs name, from `./minrootfs.tgz` to `./rootfs.tar.gz`. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com> Reviewed-by: Razvan Deaconescu <razvand@unikraft.io> Approved-by: Razvan Deaconescu <razvand@unikraft.io> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: #12
unikraft-bot
pushed a commit
that referenced
this pull request
Jul 1, 2023
Update the README with instructions on setting up, configuring, building and running the Python3 app with Unikraft. As part of it, add Makefile files, configuration files and scripts; they are referenced in the `README.md` file. Current instructions cover the use of QEMU/KVM platform (both on x86_64 and on AArch64) and GCC. Firecraker/KVM, Xen, Linux platforms and Clang are not yet documented. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com> Reviewed-by: Razvan Deaconescu <razvand@unikraft.io> Approved-by: Razvan Deaconescu <razvand@unikraft.io> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: #12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the README with instructions on setting up, configuring, building and running the Python3 app with Unikraft. As part of it, add Makefile files, configuration files and scripts; they are referenced in the
README.mdfile.Current instructions cover the use of QEMU/KVM platform (both on x86_64 and on AArch64) and GCC. Firecraker/KVM, Xen, Linux platforms and Clang are not yet documented.