Rename running scripts to run-qemu-*.sh
#15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
razvand
requested changes
Jul 4, 2023
There was a problem hiding this comment.
@StefanJum, remove the scripts and replace them with commands inside the README file, similar to the app-helloworld README file. Also rename the config-* files and remove the extra clutter inside them. This is based on the same feedback from @nderjung on the app-helloworld README file.
StefanJum
force-pushed
the
StefanJum/rename-running-scripts
branch
3 times, most recently
from
ab066da
to
43906b4
Compare
StefanJum
force-pushed
the
StefanJum/rename-running-scripts
branch
from
43906b4
to
8d7cf02
Compare
Remove the running scripts and just add the command the the `README.md` file. Also remove the `$` sign from the commands so they can be easly copy-pasted. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com>
StefanJum
force-pushed
the
StefanJum/rename-running-scripts
branch
from
8d7cf02
to
425f047
Compare
razvand
approved these changes
Jul 4, 2023
There was a problem hiding this comment.
Reviewed-by: Razvan Deaconescu razvand@unikraft.io
Approved-by: Razvan Deaconescu razvand@unikraft.io
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
.shextension was missing, which led to errors when following the instructions in theREADME.mdfile.