-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kraft.yaml: Use stable version for all components #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, @razvand. I've tested the changes on my system and here is what I have noticed:
Firstly, app-python3
uses functions from posix-event
(/home/X/apps/app-python3/build/libpython3/origin/Python-3.7.4/Modules/timemodule.c:1843: undefined reference to select
), so we need to add - CONFIG_LIBPOSIX_EVENT=y
to the kraft.yaml file.
Secondly, the app doesn't seem to work on the stable branch of Unikraft. This due to issue unikraft/unikraft#529, which is fixed by commit unikraft/unikraft@9bf6e63 found only on the staging branch.
Apart from that, everything seems fine to me.
This
Ah, damn. Please see if changing |
Oops, didn't see that PR. Yes, makes sense now.
Yes, simply changing the version to |
This has the benefit of not requiring updates whenever there is a new version release of Unikraft components. Signed-off-by: Razvan Deaconescu <razvan.deaconescu@cs.pub.ro>
597c2ed
to
e2bd90c
Compare
I fixed the PR. Please see now, @eduardvintila . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good now. Thanks, @razvand!
Reviewed-by: Eduard Vintilă eduard.vintila47@gmail.com
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tagging the core version to a commit is a temporary solution that will work for now but it is a bit ugly. In the future all app-* repos will have the version attributed to the corresponding library (and not the Unikraft internal version).
Approving for now until this migration occurs, thanks.
Approved-by: Alexander Jung alex@unikraft.org
This has the benefit of not requiring updates whenever there is a new version release of Unikraft components.