Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kraft.yaml: Use stable version for all components #7

Closed
wants to merge 1 commit into from

Conversation

razvand
Copy link
Contributor

@razvand razvand commented Aug 29, 2022

This has the benefit of not requiring updates whenever there is a new version release of Unikraft components.

Copy link
Member

@eduardvintila eduardvintila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @razvand. I've tested the changes on my system and here is what I have noticed:

Firstly, app-python3 uses functions from posix-event(/home/X/apps/app-python3/build/libpython3/origin/Python-3.7.4/Modules/timemodule.c:1843: undefined reference to select), so we need to add - CONFIG_LIBPOSIX_EVENT=y to the kraft.yaml file.

Secondly, the app doesn't seem to work on the stable branch of Unikraft. This due to issue unikraft/unikraft#529, which is fixed by commit unikraft/unikraft@9bf6e63 found only on the staging branch.

Apart from that, everything seems fine to me.

@razvand
Copy link
Contributor Author

razvand commented Aug 29, 2022

Firstly, app-python3 uses functions from posix-event(/home/X/apps/app-python3/build/libpython3/origin/Python-3.7.4/Modules/timemodule.c:1843: undefined reference to select), so we need to add - CONFIG_LIBPOSIX_EVENT=y to the kraft.yaml file.

This lib-python3 PR needs to be integrated first. Use that. It will fix things.

Secondly, the app doesn't seem to work on the stable branch of Unikraft. This due to issue unikraft/unikraft#529, which is fixed by commit unikraft/unikraft@9bf6e63 found only on the staging branch.

Apart from that, everything seems fine to me.

Ah, damn. Please see if changing stable to 9bf6e63 fixes it. Or, if not, using staging. I will then update kraft.yaml accordingly. Then we'll make a note for future update of kraft.yaml to stable.

@eduardvintila
Copy link
Member

This lib-python3 PR needs to be integrated first. Use that. It will fix things.

Oops, didn't see that PR. Yes, makes sense now.

Ah, damn. Please see if changing stable to 9bf6e63 fixes it. Or, if not, using staging. I will then update kraft.yaml accordingly. Then we'll make a note for future update of kraft.yaml to stable.

Yes, simply changing the version to staging(or 9bf6e63) seems to do the job.

This has the benefit of not requiring updates whenever there is a new
version release of Unikraft components.

Signed-off-by: Razvan Deaconescu <razvan.deaconescu@cs.pub.ro>
@razvand
Copy link
Contributor Author

razvand commented Aug 29, 2022

Yes, simply changing the version to staging(or 9bf6e63) seems to do the job.

I fixed the PR. Please see now, @eduardvintila .

Copy link
Member

@eduardvintila eduardvintila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now. Thanks, @razvand!
Reviewed-by: Eduard Vintilă eduard.vintila47@gmail.com

Copy link
Member

@nderjung nderjung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tagging the core version to a commit is a temporary solution that will work for now but it is a bit ugly. In the future all app-* repos will have the version attributed to the corresponding library (and not the Unikraft internal version).

Approving for now until this migration occurs, thanks.

Approved-by: Alexander Jung alex@unikraft.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants