This repository has been archived by the owner on Mar 4, 2024. It is now read-only.
Update README.md file with easier to use instructions #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanJum
pushed a commit
to unikraft-upb/app-sqlite
that referenced
this pull request
Jul 4, 2023
The sizeof of the array will include the trailing null byte. This causes curl to interpret the response as binary data. Signed-off-by: Marco Schlumpp <marco@unikraft.io> Reviewed-by: Razvan Virtan <virtanrazvan@gmail.com> Reviewed-by: Razvan Deaconescu <razvand@unikraft.io> Approved-by: Razvan Deaconescu <razvand@unikraft.io> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: unikraft#10
StefanJum
force-pushed
the
StefanJum/update-readme
branch
from
5c3da81
to
0a8c006
Compare
mariasfiraiala
suggested changes
Jul 30, 2023
Remove the running scripts and add the commands in the README file, rename the `config-*` files and add a `TLDR` section that summarises the setup. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com>
StefanJum
force-pushed
the
StefanJum/update-readme
branch
from
0a8c006
to
f6c6bb9
Compare
|
Done @mariasfiraiala, thank you. |
mariasfiraiala
approved these changes
Jul 30, 2023
There was a problem hiding this comment.
Nice, thanks!
Reviewed-by: Maria Sfiraiala maria.sfiraiala@gmail.com
razvand
approved these changes
Aug 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will remove the running scripts and add the commands in the README file, rename the
config-*files and add aTLDRsection that summarises the setup.