This repository has been archived by the owner on Mar 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 8
Update building and running workflows #9
Closed
StefanJum
wants to merge
2
commits into
unikraft:staging
from
unikraft-upb:StefanJum/update-app-docs
Closed
Update building and running workflows #9
StefanJum
wants to merge
2
commits into
unikraft:staging
from
unikraft-upb:StefanJum/update-app-docs
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
286841f
to
2f66707
Compare
6e185d6
to
9dd1bd2
Compare
razvand
suggested changes
Jul 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add .gitignore
file to ignore output files.
9dd1bd2
to
17122a7
Compare
Done @razvand |
razvand
suggested changes
Jul 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @StefanJum. See my comments.
Ignore files and folder that are output from the set up, configure, build or run steps. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com>
Update the README with instructions on setting up, configuring, building and running the SQLite app with Unikraft. As part of it, add Makefile files, configuration files and scripts; they are referenced in the `README.md` file. Current instructions cover the use of QEMU/KVM platform (both on x86_64 and on AArch64) and GCC. Firecraker/KVM, Xen, Linux platforms and Clang are not yet documented. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com>
17122a7
to
0b9ed05
Compare
razvand
approved these changes
Jul 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed-by: Razvan Deaconescu razvand@unikraft.io
Approved-by: Razvan Deaconescu razvand@unikraft.io
unikraft-bot
pushed a commit
that referenced
this pull request
Jul 3, 2023
Update the README with instructions on setting up, configuring, building and running the SQLite app with Unikraft. As part of it, add Makefile files, configuration files and scripts; they are referenced in the `README.md` file. Current instructions cover the use of QEMU/KVM platform (both on x86_64 and on AArch64) and GCC. Firecraker/KVM, Xen, Linux platforms and Clang are not yet documented. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com> Reviewed-by: Razvan Deaconescu <razvand@unikraft.io> Approved-by: Razvan Deaconescu <razvand@unikraft.io> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: #9
StefanJum
pushed a commit
to unikraft-upb/app-sqlite
that referenced
this pull request
Jul 4, 2023
Add `qemu-system` command for manual run. Bridge is to also be created manually before command run. Signed-off-by: Razvan Deaconescu <razvan.deaconescu@cs.pub.ro> Reviewed-by: Eduard Vintilă <eduard.vintila47@gmail.com> Approved-by: Alexander Jung <alex@unikraft.org> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Pull-Request: unikraft#9
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UK_ROOT
andUK_LIBS
to point to$(PWD)/.unikraft/...
[TODO]: Add README.md file