New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(workflows): Add linting GitHub Actions #5
Conversation
gabrielmocanu
commented
Oct 27, 2023
- Add super-linter action for linting source-code and Markdown files.
- Add spellcheck action to check for misspellings in Markdown files.
- Add super-linter action for linting source-code and Markdown files. - Add spellcheck action to check for misspellings in Markdown files. Signed-off-by: Gabriel Mocanu <gabi.mocanu98@gmail.com>
Can you make this also run on commit messages? Would be useful on multiple repos |
@craciunoiuc , you mean linting commit messages? Such as commit message length, use of prefix and others? |
Question was more directed to the spellchecker. There are always typos in commit messages and are hard to point out. For sure one hacky way would be to write the messages to files and let the spellchecker catch them |
@gabrielmocanu , is it possible to spellcheck commit messages? We can do that in a separate PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me, this looks OK. @nderjung, what are your thoughts?
Yup, it's possible, but please make another issue and assign it to me. I will do another PR for it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good here. Thanks!
Reviewed-by: Cezar Craciunoiu cezar.craciunoiu@unikraft.io
Approved-by: Cezar Craciunoiu cezar.craciunoiu@unikraft.io
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed-by: Razvan Deaconescu razvand@unikraft.io