Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workflows): Add linting GitHub Actions #5

Merged
merged 1 commit into from Dec 27, 2023

Conversation

gabrielmocanu
Copy link
Member

  • Add super-linter action for linting source-code and Markdown files.
  • Add spellcheck action to check for misspellings in Markdown files.

- Add super-linter action for linting source-code and Markdown files.
- Add spellcheck action to check for misspellings in Markdown files.

Signed-off-by: Gabriel Mocanu <gabi.mocanu98@gmail.com>
@craciunoiuc
Copy link
Member

Can you make this also run on commit messages? Would be useful on multiple repos

@razvand razvand requested a review from nderjung October 27, 2023 10:52
@razvand razvand added the enhancement New feature or request label Oct 27, 2023
@nderjung nderjung changed the title task: Add linting GitHub Actions feat(workflows): Add linting GitHub Actions Oct 27, 2023
@razvand
Copy link
Contributor

razvand commented Oct 27, 2023

Can you make this also run on commit messages? Would be useful on multiple repos

@craciunoiuc , you mean linting commit messages? Such as commit message length, use of prefix and others?

@craciunoiuc
Copy link
Member

Question was more directed to the spellchecker. There are always typos in commit messages and are hard to point out.

For sure one hacky way would be to write the messages to files and let the spellchecker catch them

@razvand
Copy link
Contributor

razvand commented Nov 9, 2023

@gabrielmocanu , is it possible to spellcheck commit messages? We can do that in a separate PR.

Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me, this looks OK. @nderjung, what are your thoughts?

@gabrielmocanu
Copy link
Member Author

@gabrielmocanu , is it possible to spellcheck commit messages? We can do that in a separate PR.

Yup, it's possible, but please make another issue and assign it to me. I will do another PR for it.

@razvand razvand self-requested a review December 27, 2023 11:43
@razvand razvand assigned razvand and unassigned nderjung Dec 27, 2023
Copy link
Member

@craciunoiuc craciunoiuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good here. Thanks!

Reviewed-by: Cezar Craciunoiu cezar.craciunoiu@unikraft.io
Approved-by: Cezar Craciunoiu cezar.craciunoiu@unikraft.io

Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Razvan Deaconescu razvand@unikraft.io

@razvand razvand merged commit 2713df8 into unikraft:main Dec 27, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants