fix(merge-oci-digests): Show --all packages
#8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following the merge of kraftkit#945, without specifying the `--all` flag, the host architecture and platform are detected and used to reduce the output. In this CI/CD context, we wish to show all variants which requires the use of this flag. Without this flag, the GitHub Actions workflow fails as it cannot determine the host platform. Signed-off-by: Alexander Jung <alex@unikraft.io>
razvand
approved these changes
Nov 2, 2023
There was a problem hiding this comment.
Thanks, @nderjung.
Reviewed-by: Razvan Deaconescu razvand@unikraft.io
Approved-by: Razvan Deaconescu razvand@unikraft.io
razvand
deleted the
nderjung/fix/github/actions/merge-oci-digests/show-all
branch
razvand
pushed a commit
to unikraft-upb/catalog
that referenced
this pull request
Dec 19, 2023
feat(utils): Introduce bincompat generator script Reviewed-by: Mihnea Firoiu <mihneafiroiu0@gmail.com> Approved-by: Stefan Jumarea <stefanjumarea02@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the merge of kraftkit#945, without specifying the
--allflag, the host architecture and platform are detected and used to reduce the output. In this CI/CD context, we wish to show all variants which requires the use of this flag. Without this flag, the GitHub Actions workflow fails as it cannot determine the host platform.