Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add awk PIE build #102

Merged
merged 1 commit into from
Oct 21, 2023
Merged

Add awk PIE build #102

merged 1 commit into from
Oct 21, 2023

Conversation

andreistan26
Copy link
Contributor

No description provided.

@razvand razvand self-requested a review October 21, 2023 14:02
@razvand razvand self-assigned this Oct 21, 2023
@razvand razvand added enhancement New feature or request kind/hackathon hacktoberfest Participation to Hacktoberfest labels Oct 21, 2023
razvand
razvand requested changes Oct 21, 2023
View reviewed changes
Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments. Use AWK as the application name.

awk/README.md Outdated Show resolved Hide resolved
awk/README.md Outdated Show resolved Hide resolved
awk/README.md Outdated Show resolved Hide resolved
awk/README.md Outdated Show resolved Hide resolved
awk/README.md Outdated Show resolved Hide resolved
awk/README.md Outdated Show resolved Hide resolved
awk/README.md Outdated Show resolved Hide resolved
@andreistan26
Add awk PIE build
437ed6e 
Signed-off-by: Andrei Stan <andreistan2003@gmail.com>
razvand
razvand approved these changes Oct 21, 2023
View reviewed changes
Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @andreistan26 .

Reviewed-by: Razvan Deaconescu razvand@unikraft.io
Approved-by: Razvan Deaconescu razvand@unikraft.io

awk/README.md

## Run a Sample AWK command Natively on Linux

Run the binary using (for example) the following commands:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Run the binary using (for example) the following commands:
Run the binary using (for example) the following command:

@razvand razvand merged commit 06551be into unikraft:master Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@razvand razvand razvand approved these changes

Assignees

@razvand razvand

Labels
enhancement New feature or request hacktoberfest Participation to Hacktoberfest kind/hackathon
Projects
(Binary) Application Compatibility
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andreistan26 @razvand