feat(internal): Allow for specifying optional measurement units #1687
+43
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this looks ok I can do it also for volumes Edit: Done |
craciunoiuc
force-pushed
the
craciunoiuc/allow-units-memory
branch
2 times, most recently
from
1e608a1
to
8de3a7d
Compare
The value is then converted to mebibytes by dividing the integer by 1024*1024. If something like ~3.2Mi are specified, the value will be truncated down to 3Mi. Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io>
craciunoiuc
force-pushed
the
craciunoiuc/allow-units-memory
branch
from
8de3a7d
to
725bdcd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite checklist
make fmton your commit series before opening this PR;Description of changes
The value is then converted to mebibytes by deviding the integer by 1024*1024. If something like ~3.2Mi are specified, the value will be truncated down to 3Mi.
GitHub-Closes: #1513