Update to upstream 1.13.0 #2
Conversation
Signed-off-by: Andrei Tatar <andrei@unikraft.io>
Signed-off-by: Andrei Tatar <andrei@unikraft.io>
There was a problem hiding this comment.
The changes look good, thanks @andreittr. Regarding the documentation part, however, the README specifies the order of the libraries which we don't use anymore (and has newlib mentioned as well - kinda obsolete).
AFAIK, the latest correct order is
LIBS := $(UK_LIBS)/lib-libcxxabi:$(UK_LIBS)/lib-libcxx:$(UK_LIBS)/lib-compiler-rt:$(UK_LIBS)/lib-libunwind:$(UK_LIBS)/lib-musl:$(UK_LIBS)/lib-googletestDo you mind changing that too @andreittr? Actually the whole README should be updated to have the md format. I can add a commit to achieve that, if you find it too cumbersome.
Good point @mariasfiraiala , thanks! I'll add a commit updating the README to be roughly in line with ones in more up-to-date libs. I'll also simplify the lib order paragraph to just "put at the end of the lib list". |
There was a problem hiding this comment.
Thanks @andreittr, 2 last comments from me below. After this, I think we should merge this.
README.md
Outdated
| Please refer to the `README.md` as well as the documentation in the | ||
| `doc/` subdirectory of the main unikraft repository for further | ||
| information. | ||
| Being a C++ library, libcxx is required. |
There was a problem hiding this comment.
| Being a C++ library, libcxx is required. | |
| Being a C++ library, `libcxx` is required. |
README.md
Outdated
| `doc/` subdirectory of the main unikraft repository for further | ||
| information. | ||
| Being a C++ library, libcxx is required. | ||
| This library should come at the end of the dependency list. |
There was a problem hiding this comment.
| This library should come at the end of the dependency list. | |
| `lib-googletest` should come at the end of the dependency list. |
It isn't clear enough what library should come last.
Reformat to Markdowm. CONTRIBUTING: remove obsolete references, point users at unikraft website README: clean up & simplify wording, point users at website Signed-off-by: Andrei Tatar <andrei@unikraft.io>
andreittr
force-pushed
the
ttr/gtest-113
branch
from
84c2b52
to
1b15338
Compare
There was a problem hiding this comment.
All good now, thanks a lot for the effort, @andreittr!
Reviewed-by: Maria Sfiraiala maria.sfiraiala@gmail.com
Signed-off-by: Andrei Tatar <andrei@unikraft.io> Reviewed-by: Maria Sfiraiala <maria.sfiraiala@gmail.com> Approved-by: Razvan Deaconescu <razvand@unikraft.io> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: #2
Reformat to Markdowm. CONTRIBUTING: remove obsolete references, point users at unikraft website README: clean up & simplify wording, point users at website Signed-off-by: Andrei Tatar <andrei@unikraft.io> Reviewed-by: Maria Sfiraiala <maria.sfiraiala@gmail.com> Approved-by: Razvan Deaconescu <razvand@unikraft.io> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: #2
Description of changes
Update Google Test to upstream 1.13.0, as well as clean up build scripts & documentation.