Add compatibility with GCC <= 11.2 & Clang 10 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GCC versions prior to 11.3 do not support the "mwait" target attribute. This change adds compiler version checks to the pragmas using this attribute, enabling builds with GCC 11.1 & 11.2. Signed-off-by: Andrei Tatar <andrei@unikraft.io>
Clang versions below 11 do not support the AMX, serialize, and tsxldtrk intrinsics. This change adds a version check when including the offending headers. Signed-off-by: Andrei Tatar <andrei@unikraft.io>
StefanJum
approved these changes
Aug 15, 2023
There was a problem hiding this comment.
All good, thanks.
Reviewed-by: Stefan Jumarea stefanjumarea02@gmail.com
mariasfiraiala
approved these changes
Aug 15, 2023
There was a problem hiding this comment.
Looks good, thanks!
Reviewed-by: Maria Sfiraiala maria.sfiraiala@gmail.com
RaduNichita
approved these changes
Aug 15, 2023
There was a problem hiding this comment.
All good, thanks @andreittr for this change! 💯
Reviewed-by: Radu Nichita radunichita99@gmail.com
razvand
approved these changes
Aug 15, 2023
unikraft-bot
pushed a commit
that referenced
this pull request
Aug 15, 2023
Clang versions below 11 do not support the AMX, serialize, and tsxldtrk intrinsics. This change adds a version check when including the offending headers. Signed-off-by: Andrei Tatar <andrei@unikraft.io> Reviewed-by: Stefan Jumarea <stefanjumarea02@gmail.com> Reviewed-by: Maria Sfiraiala <maria.sfiraiala@gmail.com> Reviewed-by: Radu Nichita <radunichita99@gmail.com> Approved-by: Razvan Deaconescu <razvand@unikraft.io> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: #4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset adds compiler version checks around problematic code not understood by older versions of compilers, enabling support for: