Skip to content

Commit

Permalink
Makefile.uk: Add minimum compiler version check
Browse files Browse the repository at this point in the history
libcxx 14 relies on some C++ features that are only implemented starting
from GCC 11 and Clang 10.
This change adds an explicit compiler version check to warn the user
about this incompatibility.

Signed-off-by: Andrei Tatar <andrei@unikraft.io>
Reviewed-by: Stefan Jumarea <stefanjumarea02@gmail.com>
Reviewed-by: Maria Sfiraiala <maria.sfiraiala@gmail.com>
Reviewed-by: Radu Nichita <radunichita99@gmail.com>
Approved-by: Razvan Deaconescu <razvand@unikraft.io>
Tested-by: Unikraft CI <monkey@unikraft.io>
GitHub-Closes: #33
  • Loading branch information
andreittr authored and unikraft-bot committed Aug 15, 2023
1 parent 6f2e5bd commit 76634ca
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions Makefile.uk
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,14 @@
################################################################################
$(eval $(call addlib_s,libcxx,$(CONFIG_LIBCXX)))

ifeq ($(CONFIG_LIBCXX),y)
ifeq ($(call have_gcc),y)
$(call error_if_gcc_version_lt,11,0)
else ifeq ($(call have_clang),y)
$(call error_if_clang_version_lt,10,0)
endif
endif

################################################################################
# Sources
################################################################################
Expand Down

0 comments on commit 76634ca

Please sign in to comment.